Skip to content

Commit fdcd1ad

Browse files
authored
ref(v7): Deprecate addRequestDataToTransaction (#11368)
This is not used/needed anymore in v8, and also is coupled to transactions. Not sure if we need to add this to migration docs, as this is from utils and was more internally used...? (Also, I guess if so we need to add it to migration docs in a separate PR on develop...?)
1 parent 926dd3d commit fdcd1ad

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

packages/node/src/handlers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ export function tracingHandler(): (
105105
// Push `transaction.finish` to the next event loop so open spans have a chance to finish before the transaction
106106
// closes
107107
setImmediate(() => {
108+
// eslint-disable-next-line deprecation/deprecation
108109
addRequestDataToTransaction(transaction, req);
109110
setHttpStatus(transaction, res.statusCode);
110111
transaction.end();

packages/utils/src/requestdata.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,9 @@ export type TransactionNamingScheme = 'path' | 'methodPath' | 'handler';
6464

6565
/**
6666
* Sets parameterized route as transaction name e.g.: `GET /users/:id`
67-
* Also adds more context data on the transaction from the request
67+
* Also adds more context data on the transaction from the request.
68+
*
69+
* @deprecated This utility will be removed in v8.
6870
*/
6971
export function addRequestDataToTransaction(
7072
transaction: Transaction | undefined,

0 commit comments

Comments
 (0)