Skip to content

Commit f6ac741

Browse files
authored
ci: fix ember flaky test (#3718)
* Fix CI ember flaky test
1 parent 8b28573 commit f6ac741

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

packages/ember/tests/acceptance/sentry-performance-test.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,13 @@ function assertSentryCall(assert, callNumber, options) {
2828
return `${s.op} | ${normalizedDescription}`;
2929
});
3030

31-
// FIXME: For some reason, the last `destroy` run queue event is not always called.
31+
// FIXME: For some reason, the last `afterRender` and `destroy` run queue event are not always called.
3232
// This is not a blocker, but should be investigated and fixed, as this is the expected output.
33-
if (event.spans[event.spans.length - 1] !== 'ember.runloop.destroy | undefined') {
33+
const lastSpan = event.spans[event.spans.length - 1];
34+
if (lastSpan === 'ember.runloop.afterRender | undefined') {
3435
event.spans.push('ember.runloop.destroy | undefined');
36+
} else if (lastSpan === 'ember.runloop.render | undefined') {
37+
event.spans.push('ember.runloop.afterRender | undefined', 'ember.runloop.destroy | undefined');
3538
}
3639

3740
assert.deepEqual(event.spans, options.spans, `Has correct spans`);

0 commit comments

Comments
 (0)