Skip to content

Commit f2a604b

Browse files
committed
Do not end express spans if they are not still recording.
1 parent fd1561e commit f2a604b

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

packages/remix/src/utils/serverAdapters/express.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,11 @@ async function finishSentryProcessing(res: AugmentedExpressResponse): Promise<vo
202202
// transaction closes, and make sure to wait until that's done before flushing events
203203
await new Promise<void>(resolve => {
204204
setImmediate(() => {
205-
span.end();
205+
// Double checking whether the span is not already finished,
206+
// OpenTelemetry gives error if we try to end a finished span
207+
if (span.isRecording()) {
208+
span.end();
209+
}
206210
resolve();
207211
});
208212
});

0 commit comments

Comments
 (0)