Skip to content

Commit f1ebcd5

Browse files
s1gr1dclaude
andcommitted
ref(vue): Keep debounce comments implementation-general
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 596399f commit f1ebcd5

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎dev-packages/e2e-tests/test-applications/vue-3/tests/performance.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,8 @@ test('sends a pageload span with a route name as span name if available', async
173173
});
174174

175175
// The mixin records render activity from every component, so the late child pushes the root
176-
// render span's end out to its own mount (#24858). The `app.mount()` wrap only observes the
177-
// root, so without the Options API the span still ends before the child mounts.
176+
// render span's end out to its own mount. The `app.mount()` wrap only observes the root, so
177+
// without the Options API the span still ends before the child mounts.
178178
test('ends the application render span at the last observed render activity', async ({ page }) => {
179179
const spansPromise = collectStreamedSpans('vue-3', spans =>
180180
spans.some(

‎packages/vue/src/tracing.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ const HOOKS: { [key in Operation]: Hook[] } = {
6464
* End the root component span once no render activity happened for `timeout` (a debounce).
6565
*
6666
* All debounce state lives on `$root`, so hooks from every component share one timer. Recording
67-
* activity is a plain property write; the timer is only re-armed when it fires early, so mounting
68-
* N components costs one timer instead of N (#24858).
67+
* activity is a plain property write; the timer only re-arms when it fires early, so a mount
68+
* costs one timer regardless of component count.
6969
*/
7070
function maybeEndRootComponentSpan(vm: VueSentry, timestamp: number, timeout: number): void {
7171
const root = vm.$root;
@@ -77,7 +77,7 @@ function maybeEndRootComponentSpan(vm: VueSentry, timestamp: number, timeout: nu
7777
}
7878

7979
/**
80-
* Fires `timeout` after the activity it was armed for. Activity recorded in the meantime pushes
80+
* Fires `delayMs` after the activity it was armed for. Activity recorded in the meantime pushes
8181
* the deadline out by the recorded gap, so the span always ends at the last activity timestamp.
8282
*/
8383
function armRootComponentSpanTimer(root: VueSentry, armedFor: number, delayMs: number): void {

0 commit comments

Comments
 (0)