Skip to content

Commit e53a66a

Browse files
committed
Fixed incorrect span check
1 parent d81ba39 commit e53a66a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/ember/tests/acceptance/sentry-performance-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ function assertSentryCall(assert, callNumber, options) {
3030

3131
// FIXME: For some reason, the last `afterRender` and `destroy` run queue event are not always called.
3232
// This is not a blocker, but should be investigated and fixed, as this is the expected output.
33-
if (event.spans[event.spans.length - 1] !== 'ember.runloop.afterRender | undefined') {
34-
event.spans.push('ember.runloop.afterRender | undefined');
35-
}
36-
if (event.spans[event.spans.length - 1] !== 'ember.runloop.destroy | undefined') {
33+
const lastSpan = event.spans[event.spans.length - 1];
34+
if (lastSpan === 'ember.runloop.afterRender | undefined') {
3735
event.spans.push('ember.runloop.destroy | undefined');
36+
} else if (lastSpan === 'ember.runloop.render | undefined') {
37+
event.spans.push('ember.runloop.afterRender | undefined', 'ember.runloop.destroy | undefined');
3838
}
3939

4040
assert.deepEqual(event.spans, options.spans, `Has correct spans`);

0 commit comments

Comments
 (0)