Initial work on fixing eval frame regexes

Author: benvinegar

dist/sri.json

@@ -1,20 +1,20 @@
 {
   "@dist/raven.js": {
     "hashes": {
-      "sha256": "DqjGfkHlXEUoWD0W2CirZy+/TcbA2bWYVZGM4GICEwc=",
-      "sha512": "pEOdKiz/v/gFCOIrBNn9R/Cg/z2a+oGEnwqs5h//UGAQ3ODQxdKfKvVotG+hw0z+R57+g07af2l9oOqcjcu53g=="
+      "sha256": "E/wI8NelG3dYEnnxU9HEJe4ewfiL/X6gLVSZD3P9oL0=",
+      "sha512": "eUbBW3tVAkKIgYBOIf0voVKCq1kiBXb9aJtffsaeXTZEjbWxcxdcu95zz2jXqXJ3XIwcUnf1nggJLzyhQ08Y5Q=="
     },
     "type": null,
-    "integrity": "sha256-DqjGfkHlXEUoWD0W2CirZy+/TcbA2bWYVZGM4GICEwc= sha512-pEOdKiz/v/gFCOIrBNn9R/Cg/z2a+oGEnwqs5h//UGAQ3ODQxdKfKvVotG+hw0z+R57+g07af2l9oOqcjcu53g==",
+    "integrity": "sha256-E/wI8NelG3dYEnnxU9HEJe4ewfiL/X6gLVSZD3P9oL0= sha512-eUbBW3tVAkKIgYBOIf0voVKCq1kiBXb9aJtffsaeXTZEjbWxcxdcu95zz2jXqXJ3XIwcUnf1nggJLzyhQ08Y5Q==",
     "path": "dist/raven.js"
   },
   "@dist/raven.min.js": {
     "hashes": {
-      "sha256": "rQKHhUx4JZkHPhu3S2kaqiCLZEOuVBP9W6K6LZMeSPI=",
-      "sha512": "xnf3jkR3/5vLX/GSvRlZnJJMfzP4I1oFMyINzQGq9+2esFgSywjARxwYG/ypRnCxJyNhBH3jxdNBHN0UEy/30w=="
+      "sha256": "j2LqEVKhSw6GsWF+xY3ePCxUsR7gagPL0zc/5R1TDxs=",
+      "sha512": "SGdvwIbE9KIsEWyE5BRG48mAxqPweyIjE+/nz7bOTAMlkBf2ZNi6C5T0VyLBiIolN7QkfSPCyy9z//mcEQJeAg=="
     },
     "type": null,
-    "integrity": "sha256-rQKHhUx4JZkHPhu3S2kaqiCLZEOuVBP9W6K6LZMeSPI= sha512-xnf3jkR3/5vLX/GSvRlZnJJMfzP4I1oFMyINzQGq9+2esFgSywjARxwYG/ypRnCxJyNhBH3jxdNBHN0UEy/30w==",
+    "integrity": "sha256-j2LqEVKhSw6GsWF+xY3ePCxUsR7gagPL0zc/5R1TDxs= sha512-SGdvwIbE9KIsEWyE5BRG48mAxqPweyIjE+/nz7bOTAMlkBf2ZNi6C5T0VyLBiIolN7QkfSPCyy9z//mcEQJeAg==",
     "path": "dist/raven.min.js"
   }
 }

example/index.html

@@ -33,6 +33,7 @@
 <button onclick="divide(1, 0)">Sourcemap breakage</button>
 <button onclick="derp()">window.onerror</button>
 <button onclick="testOptions()">test options</button>
+<button onclick="throwEval()">throw eval</button>
 <button onclick="testSynthetic()">test synthetic</button>
 <button onclick="throwString()">throw string</button>
 <button onclick="showDialog()">show dialog</button>

example/scratch.js

@@ -41,6 +41,10 @@ function throwString() {
     throw 'oops';
 }
 
+function throwEval() {
+    eval('derp();');
+}
+
 function showDialog() {
     broken();
     Raven.showReportDialog();

test/vendor/fixtures/captured-errors.js

@@ -333,6 +333,16 @@ CapturedExceptions.CHROME_48_BLOB = {
     "    at n.handle (blob:http%3A//localhost%3A8080/abfc40e9-4742-44ed-9dcd-af8f99a29379:7:2863)"
 };
 
+CapturedExceptions.CHROME_56_EVAL = {
+    message: 'fdas is not defined',
+    name: 'ReferenceError',
+    stack: 'ReferenceError: fdas is not defined\n' +
+    '    at derp (http://localhost:8080/example/scratch.js:31:5)\n' +
+    '    at eval (eval at throwEval (http://localhost:8080/example/scratch.js:45:5), <anonymous>:1:1)\n' +
+    '    at throwEval (http://localhost:8080/example/scratch.js:45:5)\n' +
+    '    at HTMLButtonElement.onclick (http://localhost:8080/example/:36:31)'
+};
+
 CapturedExceptions.PHANTOMJS_1_19 = {
     stack: "Error: foo\n" +
     "    at file:///path/to/file.js:878\n" +
@@ -351,6 +361,17 @@ CapturedExceptions.FIREFOX_50_RESOURCE_URL = {
     name: 'TypeError'
 };
 
+CapturedExceptions.FIREFOX_51_EVAL = {
+    stack: '@http://localhost:8080/example/scratch.js line 45 > eval:1:1\n' +
+    'throwEval@http://localhost:8080/example/scratch.js:45:5\n' +
+    'onclick@http://localhost:8080/example/:1:1\n',
+    fileName: 'http://localhost:8080/example/scratch.js line 45 > eval', // this is the .fileName property
+    lineNumber: 1,
+    columnNumber: 1,
+    message: 'lol is not defined',
+    name: 'ReferenceError'
+}
+
 CapturedExceptions.ANDROID_REACT_NATIVE = {
     message: 'Error: test',
     name: 'Error',

test/vendor/tracekit-parser.test.js

@@ -216,6 +216,14 @@ describe('TraceKit', function () {
             assert.deepEqual(stackFrames.stack.length, 3);
             assert.deepEqual(stackFrames.stack[0], { url: 'resource://path/data/content/bundle.js', func: 'render', args: [], line: 5529, column: 16 });
         });
+
+        it('should parse Firefox errors with eval URLs', function () {
+            var stackFrames = TraceKit.computeStackTrace(CapturedExceptions.FIREFOX_51_EVAL);
+            assert.ok(stackFrames);
+            assert.deepEqual(stackFrames.stack.length, 3);
+            assert.deepEqual(stackFrames.stack[0], { url: 'http://localhost:8080/example/scratch.js', func: '?', args: [], line: 45, column: null });
+        });
+
         it('should parse React Native errors on Android', function () {
             var stackFrames = TraceKit.computeStackTrace(CapturedExceptions.ANDROID_REACT_NATIVE);
             assert.ok(stackFrames);