Skip to content

Commit d20b04f

Browse files
committed
use conventions more
1 parent 7c4bfcb commit d20b04f

4 files changed

Lines changed: 12 additions & 10 deletions

File tree

  • dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/multiple-redirects/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
} from '@sentry/core';
88
import { sentryTest } from '../../../../../utils/fixtures';
99
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';
10+
import { URL_FULL, URL_PATH } from '@sentry/conventions/attributes';
1011

1112
sentryTest(
1213
'creates a pageload and navigation root spans each with multiple navigation.redirect childspans',
@@ -57,8 +58,8 @@ sentryTest(
5758
'sentry.op': 'navigation.redirect',
5859
'sentry.origin': 'auto.navigation.browser',
5960
'sentry.source': 'url',
60-
'url.full': expect.any(String),
61-
'url.path': expect.any(String),
61+
[URL_FULL]: expect.any(String),
62+
[URL_PATH]: expect.any(String),
6263
},
6364
description: expect.stringContaining('/sub-page-redirect-'),
6465
op: 'navigation.redirect',

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-redirect/pageload-redirect/test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
} from '@sentry/core';
88
import { sentryTest } from '../../../../../utils/fixtures';
99
import { envelopeRequestParser, shouldSkipTracingTest, waitForTransactionRequest } from '../../../../../utils/helpers';
10+
import { URL_FULL, URL_PATH } from '@sentry/conventions/attributes';
1011

1112
sentryTest('creates a pageload root span with navigation.redirect childspan', async ({ getLocalTestUrl, page }) => {
1213
if (shouldSkipTracingTest()) {
@@ -53,8 +54,8 @@ sentryTest('creates a pageload root span with navigation.redirect childspan', as
5354
'sentry.op': 'navigation.redirect',
5455
'sentry.origin': 'auto.navigation.browser',
5556
'sentry.source': 'url',
56-
'url.full': 'http://sentry-test.io/sub-page',
57-
'url.path': '/sub-page',
57+
[URL_FULL]: 'http://sentry-test.io/sub-page',
58+
[URL_PATH]: '/sub-page',
5859
},
5960
description: '/sub-page',
6061
op: 'navigation.redirect',

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/navigation-streamed/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
SEMANTIC_ATTRIBUTE_SENTRY_SDK_INTEGRATIONS,
99
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
1010
} from '@sentry/core';
11-
import { SENTRY_TRACE_LIFECYCLE } from '@sentry/conventions/attributes';
11+
import { SENTRY_TRACE_LIFECYCLE, URL_FULL, URL_PATH } from '@sentry/conventions/attributes';
1212
import { sentryTest } from '../../../../utils/fixtures';
1313
import { shouldSkipTracingTest } from '../../../../utils/helpers';
1414
import {
@@ -92,11 +92,11 @@ sentryTest('starts a streamed navigation span on page navigation', async ({ brow
9292
type: 'string',
9393
value: expect.any(String),
9494
},
95-
'url.full': {
95+
[URL_FULL]: {
9696
type: 'string',
9797
value: expect.any(String),
9898
},
99-
'url.path': {
99+
[URL_PATH]: {
100100
type: 'string',
101101
value: expect.any(String),
102102
},

dev-packages/browser-integration-tests/suites/tracing/browserTracingIntegration/pageload-streamed/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
SEMANTIC_ATTRIBUTE_SENTRY_SEGMENT_NAME,
1313
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
1414
} from '@sentry/core';
15-
import { SENTRY_TRACE_LIFECYCLE } from '@sentry/conventions/attributes';
15+
import { SENTRY_TRACE_LIFECYCLE, URL_FULL, URL_PATH } from '@sentry/conventions/attributes';
1616
import { sentryTest } from '../../../../utils/fixtures';
1717
import { shouldSkipTracingTest } from '../../../../utils/helpers';
1818
import { getSpanOp, getSpansFromEnvelope, waitForStreamedSpanEnvelope } from '../../../../utils/spanUtils';
@@ -81,11 +81,11 @@ sentryTest(
8181
type: 'string',
8282
value: expect.any(String),
8383
},
84-
'url.full': {
84+
[URL_FULL]: {
8585
type: 'string',
8686
value: expect.any(String),
8787
},
88-
'url.path': {
88+
[URL_PATH]: {
8989
type: 'string',
9090
value: expect.any(String),
9191
},

0 commit comments

Comments
 (0)