Commit cc0dc3b
authored
fix(node-core): Reduce bundle size by removing apm-js-collab and requiring pino >= 9.10 (#18631)
We discussed this in Bikeshedding, apm-js runtime hooks gets bundled in
frameworks still using CJS like Next.js, even if the user was not using
Pino integration at all. Attempts to tree-shake it failed as Next.js is
still using CJS.
We can drop support for older versions of Pino, given that `pino@9.10`
already exposes a tracing channel that we use, and that the injected
channel was a backup for `pino<9.10`
This will reduce bundle sizes and ensure frameworks incapable of esm
tree-shaking don't pick it up as a dependency.
I will remove `@apm-js-collab/tracing-hooks` as a dep from `node-core`
since nothing else uses it.
closes #181991 parent 7cd2abb commit cc0dc3b
File tree
9 files changed
+11
-93
lines changed- dev-packages/node-integration-tests
- packages
- core/src/utils
- node-core
- src
- integrations
- light
- sdk
9 files changed
+11
-93
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
7 | 13 | | |
8 | 14 | | |
9 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | 57 | | |
60 | 58 | | |
61 | 59 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
103 | 102 | | |
104 | 103 | | |
105 | 104 | | |
106 | 105 | | |
107 | 106 | | |
108 | | - | |
109 | 107 | | |
110 | 108 | | |
111 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
128 | 127 | | |
129 | 128 | | |
130 | 129 | | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | 130 | | |
144 | 131 | | |
145 | 132 | | |
| |||
192 | 179 | | |
193 | 180 | | |
194 | 181 | | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | 182 | | |
201 | 183 | | |
202 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
121 | 120 | | |
122 | 121 | | |
123 | 122 | | |
124 | | - | |
125 | | - | |
126 | 123 | | |
127 | 124 | | |
128 | 125 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
135 | 134 | | |
136 | 135 | | |
137 | 136 | | |
138 | | - | |
139 | | - | |
140 | 137 | | |
141 | 138 | | |
142 | 139 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
381 | | - | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
388 | | - | |
389 | | - | |
390 | | - | |
391 | | - | |
392 | | - | |
393 | | - | |
394 | | - | |
395 | 381 | | |
396 | 382 | | |
397 | 383 | | |
| |||
24778 | 24764 | | |
24779 | 24765 | | |
24780 | 24766 | | |
24781 | | - | |
24782 | | - | |
24783 | | - | |
24784 | | - | |
| 24767 | + | |
| 24768 | + | |
| 24769 | + | |
| 24770 | + | |
24785 | 24771 | | |
24786 | 24772 | | |
24787 | 24773 | | |
| |||
0 commit comments