Skip to content

Commit cbfe9f3

Browse files
authored
fix(ember): Fix embroider-safe not working on builds (#3503)
* fix(ember): Fix embroider-safe not working on builds Updated and more carefully pinned our ember-source and embroider packages.
1 parent cca6fcf commit cbfe9f3

File tree

2 files changed

+15
-23
lines changed

2 files changed

+15
-23
lines changed

packages/ember/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"pack": "npm pack"
3232
},
3333
"dependencies": {
34-
"@embroider/macros": ">=0.25.0",
34+
"@embroider/macros": "~0.37.0",
3535
"@sentry/browser": "6.3.5",
3636
"@sentry/tracing": "6.3.5",
3737
"@sentry/types": "6.3.5",
@@ -43,7 +43,7 @@
4343
},
4444
"devDependencies": {
4545
"@ember/optional-features": "^1.3.0",
46-
"@embroider/test-setup": "^0.35.1",
46+
"@embroider/test-setup": "~0.37.0",
4747
"@glimmer/component": "^1.0.0",
4848
"@glimmer/tracking": "^1.0.0",
4949
"@sentry-internal/eslint-config-sdk": "6.3.5",
@@ -67,7 +67,7 @@
6767
"ember-qunit": "^4.6.0",
6868
"ember-resolver": "^8.0.0",
6969
"ember-sinon-qunit": "^5.0.0",
70-
"ember-source": "^3.24.0",
70+
"ember-source": "~3.24.0",
7171
"ember-source-channel-url": "^2.0.1",
7272
"ember-template-lint": "^2.9.1",
7373
"ember-test-selectors": "^4.1.0",

yarn.lock

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,7 +1111,7 @@
11111111
resolve "^1.8.1"
11121112
semver "^7.3.2"
11131113

1114-
"@embroider/macros@0.37.0", "@embroider/macros@>=0.25.0":
1114+
"@embroider/macros@0.37.0", "@embroider/macros@~0.37.0":
11151115
version "0.37.0"
11161116
resolved "https://registry.yarnpkg.com/@embroider/macros/-/macros-0.37.0.tgz#221013fc5bc0eaa78f1de98802fc03e588bfe1b1"
11171117
integrity sha512-VItxn4NzGR5prryXGbPGTuLMd+QPPKvAYZv2357iS+wmz6mTzC5nqXljwDQIOJbAji9giDO+FW2HzXYOcY3teQ==
@@ -1126,10 +1126,10 @@
11261126
resolve "^1.8.1"
11271127
semver "^7.3.2"
11281128

1129-
"@embroider/test-setup@^0.35.1":
1130-
version "0.35.1"
1131-
resolved "https://registry.yarnpkg.com/@embroider/test-setup/-/test-setup-0.35.1.tgz#34999b383aa7ab4bcd7c30c7e26c1ca970fc074a"
1132-
integrity sha512-QXXKmPZp91ge/3KCLSbDzV35K05NZqMNZEnHc1XIcJcAb3tbmcN5nPk+hzV4PIT685FcvTIk60aw+dy1FJ0kNw==
1129+
"@embroider/test-setup@~0.37.0":
1130+
version "0.37.0"
1131+
resolved "https://registry.yarnpkg.com/@embroider/test-setup/-/test-setup-0.37.0.tgz#4c0590c8c3e45813dd53b8b551206acd0a49cefd"
1132+
integrity sha512-4jme5zEonjGvKeyVRygyXmooMuwmaa3nBiIxwbkRA6KWh0BLyZSqPwlQl93s7IT7S5PO5U9TqNiqI4yp2k5T7Q==
11331133
dependencies:
11341134
lodash "^4.17.20"
11351135
resolve "^1.17.0"
@@ -1331,13 +1331,6 @@
13311331
resolved "https://registry.yarnpkg.com/@glimmer/validator/-/validator-0.44.0.tgz#03d127097dc9cb23052cdb7fcae59d0a9dca53e1"
13321332
integrity sha512-i01plR0EgFVz69GDrEuFgq1NheIjZcyTy3c7q+w7d096ddPVeVcRzU3LKaqCfovvLJ+6lJx40j45ecycASUUyw==
13331333

1334-
"@glimmer/vm-babel-plugins@0.77.5":
1335-
version "0.77.5"
1336-
resolved "https://registry.yarnpkg.com/@glimmer/vm-babel-plugins/-/vm-babel-plugins-0.77.5.tgz#daffb6507aa6b08ec36f69d652897d339fdd0007"
1337-
integrity sha512-jTBM7fJMrIEy4/bCeI8e7ypR+AuWYzLA+KORCGbnTJtL/NYg4G8qwhQAZBtg1d3KmoqyqaCsyqE6f4/tzJO4eQ==
1338-
dependencies:
1339-
babel-plugin-debug-macros "^0.3.4"
1340-
13411334
"@glimmer/vm@^0.42.2":
13421335
version "0.42.2"
13431336
resolved "https://registry.yarnpkg.com/@glimmer/vm/-/vm-0.42.2.tgz#492a4f05eac587c3a37371b3c62593f20bef553d"
@@ -8585,16 +8578,15 @@ ember-source-channel-url@^3.0.0:
85858578
dependencies:
85868579
node-fetch "^2.6.0"
85878580

8588-
ember-source@^3.24.0:
8589-
version "3.26.1"
8590-
resolved "https://registry.yarnpkg.com/ember-source/-/ember-source-3.26.1.tgz#8c9e8a314fb0da447b944d64f9d92a80a628d7b5"
8591-
integrity sha512-5/NATBo5h9m1N52ITVksmjtGlYhGHLl4lDErAWv5/DC9zYe9ZR93NtymR6PEqrRilXc2x0KWd3NlOsWUoJRUOw==
8581+
ember-source@~3.24.0:
8582+
version "3.24.4"
8583+
resolved "https://registry.yarnpkg.com/ember-source/-/ember-source-3.24.4.tgz#db3f70cbe4155d48474177f1564627a1fc980f64"
8584+
integrity sha512-C5sFGxT743n2PCaTnpvy3GWHdPz+/Ve9qjcSdfRjUvFCSYNhsRkxkpXRvXEU8WoUXY35Pm4vV9RsiorX1M+/Tw==
85928585
dependencies:
85938586
"@babel/helper-module-imports" "^7.8.3"
85948587
"@babel/plugin-transform-block-scoping" "^7.8.3"
85958588
"@babel/plugin-transform-object-assign" "^7.8.3"
85968589
"@ember/edition-utils" "^1.2.0"
8597-
"@glimmer/vm-babel-plugins" "0.77.5"
85988590
babel-plugin-debug-macros "^0.3.3"
85998591
babel-plugin-filter-imports "^4.0.0"
86008592
broccoli-concat "^4.2.4"
@@ -8611,9 +8603,9 @@ ember-source@^3.24.0:
86118603
ember-cli-version-checker "^5.1.1"
86128604
ember-router-generator "^2.0.0"
86138605
inflection "^1.12.0"
8614-
jquery "^3.5.1"
8606+
jquery "^3.5.0"
86158607
resolve "^1.17.0"
8616-
semver "^7.3.4"
8608+
semver "^6.1.1"
86178609
silent-error "^1.1.1"
86188610

86198611
ember-template-lint@^2.9.1:
@@ -12600,7 +12592,7 @@ jmespath@0.15.0:
1260012592
resolved "https://registry.yarnpkg.com/jmespath/-/jmespath-0.15.0.tgz#a3f222a9aae9f966f5d27c796510e28091764217"
1260112593
integrity sha1-o/Iiqarp+Wb10nx5ZRDigJF2Qhc=
1260212594

12603-
jquery@^3.5.1:
12595+
jquery@^3.5.0:
1260412596
version "3.6.0"
1260512597
resolved "https://registry.yarnpkg.com/jquery/-/jquery-3.6.0.tgz#c72a09f15c1bdce142f49dbf1170bdf8adac2470"
1260612598
integrity sha512-JVzAR/AjBvVt2BmYhxRCSYysDsPcssdmTFnzyLEts9qNwmjmu4JTAMYubEfwVOSwpQ1I1sKKFcxhZCI2buerfw==

0 commit comments

Comments
 (0)