Skip to content

Commit c1e8f46

Browse files
committed
Unskip node-fastify-4/5 API route transaction e2e tests
Re-enabled now that the streamlined fastify integration (#21706) names spans at creation instead of renaming via updateName(), so the SentryTracerProvider no longer stamps sentry.source: 'custom'. Verified locally via e2e (11/11 pass each).
1 parent 0ec4256 commit c1e8f46

2 files changed

Lines changed: 2 additions & 12 deletions

File tree

dev-packages/e2e-tests/test-applications/node-fastify-4/tests/transactions.test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
33

4-
// TODO(provider): The SentryTracerProvider (now the default for @sentry/node) creates native spans,
5-
// so the vendored fastify instrumentation renaming hook spans via `span.updateName()` in its
6-
// `spanStart` listener stamps `sentry.source: 'custom'` on them. The OTel SDK path never set a source
7-
// on these child spans, so this assertion fails. The fix is to name the span at creation in the
8-
// instrumentation instead of renaming it (cf. the fastify streamlining in #21706); re-enable then.
9-
test.skip('Sends an API route transaction', async ({ baseURL }) => {
4+
test('Sends an API route transaction', async ({ baseURL }) => {
105
const pageloadTransactionEventPromise = waitForTransaction('node-fastify-4', transactionEvent => {
116
return (
127
transactionEvent?.contexts?.trace?.op === 'http.server' &&

dev-packages/e2e-tests/test-applications/node-fastify-5/tests/transactions.test.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
import { expect, test } from '@playwright/test';
22
import { waitForTransaction } from '@sentry-internal/test-utils';
33

4-
// TODO(provider): The SentryTracerProvider (now the default for @sentry/node) creates native spans,
5-
// so the vendored fastify instrumentation renaming hook spans via `span.updateName()` in its
6-
// `spanStart` listener stamps `sentry.source: 'custom'` on them. The OTel SDK path never set a source
7-
// on these child spans, so this assertion fails. The fix is to name the span at creation in the
8-
// instrumentation instead of renaming it (cf. the fastify streamlining in #21706); re-enable then.
9-
test.skip('Sends an API route transaction', async ({ baseURL }) => {
4+
test('Sends an API route transaction', async ({ baseURL }) => {
105
const pageloadTransactionEventPromise = waitForTransaction('node-fastify-5', transactionEvent => {
116
return (
127
transactionEvent?.contexts?.trace?.op === 'http.server' &&

0 commit comments

Comments
 (0)