small fixes

getsentry · Jul 1, 2024 · bacf357 · bacf357
1 parent 857a688
commit bacf357
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/dev-packages/browser-integration-tests/loader-suites/loader/noOnLoad/replay/test.ts b/dev-packages/browser-integration-tests/loader-suites/loader/noOnLoad/replay/test.ts
@@ -3,9 +3,11 @@ import { expect } from '@playwright/test';
 import { sentryTest } from '../../../../utils/fixtures';
 import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../../../../utils/replayHelpers';
 
+const bundle = process.env.PW_BUNDLE || '';
+
 sentryTest('should capture a replay', async ({ getLocalTestUrl, page }) => {
   // When in buffer mode, there will not be a replay by default
-  if (shouldSkipReplayTest() || process.env.PW_BUNDLE === 'loader_replay_buffer') {
+  if (shouldSkipReplayTest() || bundle === 'loader_replay_buffer') {
     sentryTest.skip();
   }
 

diff --git a/dev-packages/browser-integration-tests/loader-suites/loader/noOnLoad/replayError/test.ts b/dev-packages/browser-integration-tests/loader-suites/loader/noOnLoad/replayError/test.ts
@@ -24,7 +24,7 @@ sentryTest('should capture a replay & attach an error', async ({ getLocalTestUrl
 
   const errorEventData = envelopeRequestParser(reqError);
   expect(errorEventData.exception?.values?.length).toBe(1);
-  expect(errorEventData.exception?.values?.[0]?.value).toBe('window.doSomethingWrong is not a function');
+  expect(errorEventData.exception?.values?.[0]?.value).toContain('window.doSomethingWrong is not a function');
 
   const eventData = getReplayEvent(await req);
 

diff --git a/dev-packages/browser-integration-tests/suites/replay/errors/immediateError/test.ts b/dev-packages/browser-integration-tests/suites/replay/errors/immediateError/test.ts
@@ -26,7 +26,7 @@ sentryTest(
 
     const errorEventData = envelopeRequestParser(reqError);
     expect(errorEventData.exception?.values?.length).toBe(1);
-    expect(errorEventData.exception?.values?.[0]?.value).toBe('window.doSomethingWrong is not a function');
+    expect(errorEventData.exception?.values?.[0]?.value).toContain('window.doSomethingWrong is not a function');
 
     const eventData = getReplayEvent(await req);