Skip to content

Commit b9590c4

Browse files
committed
fixing typying for transaction in runner
1 parent d62a967 commit b9590c4

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

dev-packages/node-integration-tests/suites/tracing/amqplib/test.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import type { TransactionEvent } from '@sentry/types';
12
import { cleanupChildProcesses, createRunner } from '../../../utils/runner';
23

34
jest.setTimeout(30_000);
@@ -35,16 +36,16 @@ describe('amqplib auto-instrumentation', () => {
3536
readyMatches: ['Time to start RabbitMQ'],
3637
})
3738
.expect({
38-
transaction: (transaction: any) => {
39+
transaction: (transaction: TransactionEvent) => {
3940
expect(transaction.transaction).toEqual('Test Server Start1');
40-
expect(transaction.spans.length).toEqual(1);
41-
expect(transaction.spans[0]).toMatchObject(EXPECTED_MESSAGE_SPAN_PRODUCER);
41+
expect(transaction.spans?.length).toEqual(1);
42+
expect(transaction.spans![0]).toMatchObject(EXPECTED_MESSAGE_SPAN_PRODUCER);
4243
},
4344
})
4445
.expect({
45-
transaction: (transaction: any) => {
46+
transaction: (transaction: TransactionEvent) => {
4647
expect(transaction.transaction).toEqual('queue1 process');
47-
expect(transaction.contexts.trace).toMatchObject(EXPECTED_MESSAGE_SPAN_CONSUMER);
48+
expect(transaction.contexts?.trace).toMatchObject(EXPECTED_MESSAGE_SPAN_CONSUMER);
4849
},
4950
})
5051
.start(done);

dev-packages/node-integration-tests/utils/runner.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import type {
1111
SerializedCheckIn,
1212
SerializedSession,
1313
SessionAggregates,
14+
TransactionEvent,
1415
} from '@sentry/types';
1516
import axios from 'axios';
1617
import { createBasicSentryServer } from './server';
@@ -151,7 +152,7 @@ type Expected =
151152
event: Partial<Event> | ((event: Event) => void);
152153
}
153154
| {
154-
transaction: Partial<Event> | ((event: Event) => void);
155+
transaction: Partial<TransactionEvent> | ((event: TransactionEvent) => void);
155156
}
156157
| {
157158
session: Partial<SerializedSession> | ((event: SerializedSession) => void);
@@ -317,7 +318,7 @@ export function createRunner(...paths: string[]) {
317318
}
318319

319320
if ('transaction' in expected) {
320-
const event = item[1] as Event;
321+
const event = item[1] as TransactionEvent;
321322
if (typeof expected.transaction === 'function') {
322323
expected.transaction(event);
323324
} else {

0 commit comments

Comments
 (0)