Simplify _normalizeFrame edgecase and comment on event factories

Author: kamilogorek

src/raven.js

@@ -1387,21 +1387,6 @@ Raven.prototype = {
   },
 
   _normalizeFrame: function(frame, stackInfoUrl) {
-    if (!frame.url) {
-      // Case when we don't have any information about the error
-      // E.g. throwing a string or raw object in Firefox
-      // Generating synthetic error doesn't add any value here
-      //
-      // We should probably somehow let user know that he should fix his code
-      return {
-        filename: stackInfoUrl, // fallback to whole stacks url from onerror handler
-        lineno: frame.line,
-        colno: frame.column,
-        function: frame.func || '?', // if we dont have a file url, we most likely won't have  a function name either
-        in_app: true // this will always come from the user's code
-      };
-    }
-
     // normalize the frames data
     var normalized = {
       filename: frame.url,
@@ -1410,6 +1395,15 @@ Raven.prototype = {
       function: frame.func || '?'
     };
 
+    // Case when we don't have any information about the error
+    // E.g. throwing a string or raw object, instead of an `Error` in Firefox
+    // Generating synthetic error doesn't add any value here
+    //
+    // We should probably somehow let a user know that they should fix their code
+    if (!frame.url) {
+      normalized.filename = stackInfoUrl; // fallback to whole stacks url from onerror handler
+    }
+
     normalized.in_app = !// determine if an exception came from outside of our app
     // first we check the global includePaths list.
     (

test/integration/frame.html

@@ -38,8 +38,22 @@
         };
     }());
 
-    // Custom event factories for cross-browser compatibility
-
+    /**
+     * Custom event factories for cross-browser compatibility
+     *
+     * Gecko browsers are using non-standard `initKeyEvent`, where others implemented `initKeyboardEvent`.
+     * To make it more consistent, we try to use standardized `MouseEvent`/`KeyboardEvent` now
+     * and fallback to older implementations for legacy browsers only.
+     *
+     * See deprecation notes:
+     * https://developer.mozilla.org/en-US/docs/Web/API/Document/createEvent
+     * https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/initKeyEvent
+     * https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/initKeyboardEvent
+     *
+     * References:
+     * https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent#Specifications
+     * https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#Specifications
+     */
     function createMouseEvent (options) {
       var options = {
         bubbles: true,
@@ -62,14 +76,14 @@
       }
     }
 
-    function createKeyboardEvent (key = 'a') {
+    function createKeyboardEvent (key) {
       var options = {
         bubbles: true,
         cancelable: true,
         view: window,
-        key: key,
-        charCode: key.charCodeAt()
+        key: key || 'a'
       }
+      options.charCode = options.key.charCodeAt();
 
       if ('KeyboardEvent' in window) {
         return new KeyboardEvent('keypress', options);