Skip to content

Commit b360ead

Browse files
committed
ref(feedback): Create stub integrations for feedback modal & screenshot code ot be broken out of the main integration
1 parent ae84d1a commit b360ead

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+778
-25
lines changed

.craft.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,15 @@ targets:
3232
- name: npm
3333
id: '@sentry-internal/feedback'
3434
includeNames: /^sentry-internal-feedback-\d.*\.tgz$/
35-
## 1.8 ReplayCanvas package (browser only)
35+
## 1.8 Feedback Modal package (browser only)
36+
- name: npm
37+
id: '@sentry-internal/feedback-modal'
38+
includeNames: /^sentry-internal-feedback-modal-\d.*\.tgz$/
39+
## 1.9 Feedback Screenshot package (browser only)
40+
- name: npm
41+
id: '@sentry-internal/feedback-screenshot'
42+
includeNames: /^sentry-internal-feedback-screenshot-\d.*\.tgz$/
43+
## 1.10 ReplayCanvas package (browser only)
3644
- name: npm
3745
id: '@sentry-internal/replay-canvas'
3846
includeNames: /^sentry-internal-replay-canvas-\d.*\.tgz$/

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,8 @@ jobs:
106106
- 'packages/replay/**'
107107
- 'packages/replay-canvas/**'
108108
- 'packages/feedback/**'
109+
- 'packages/feedback-modal/**'
110+
- 'packages/feedback-screenshot/**'
109111
- 'packages/wasm/**'
110112
browser_integration:
111113
- *shared

CODEOWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@ packages/replay @getsentry/replay-sdk-web
22
packages/replay-worker @getsentry/replay-sdk-web
33
packages/replay-canvas @getsentry/replay-sdk-web
44
packages/feedback @getsentry/replay-sdk-web
5+
packages/feedback-modal @getsentry/replay-sdk-web
6+
packages/feedback-screenshot @getsentry/replay-sdk-web
57
dev-packages/browser-integration-tests/suites/replay @getsentry/replay-sdk-web

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@
5555
"packages/eslint-config-sdk",
5656
"packages/eslint-plugin-sdk",
5757
"packages/feedback",
58+
"packages/feedback-modal",
59+
"packages/feedback-screenshot",
5860
"packages/gatsby",
5961
"packages/google-cloud-serverless",
6062
"packages/integration-shims",

packages/browser/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@
4343
},
4444
"dependencies": {
4545
"@sentry-internal/feedback": "8.0.0-alpha.7",
46+
"@sentry-internal/feedback-modal": "8.0.0-alpha.7",
47+
"@sentry-internal/feedback-screenshot": "8.0.0-alpha.7",
4648
"@sentry-internal/replay": "8.0.0-alpha.7",
4749
"@sentry-internal/replay-canvas": "8.0.0-alpha.7",
4850
"@sentry-internal/tracing": "8.0.0-alpha.7",

packages/browser/src/index.bundle.feedback.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
// This is exported so the loader does not fail when switching off Replay/Tracing
2+
23
import { feedbackIntegration, getFeedback } from '@sentry-internal/feedback';
4+
import { feedbackModalIntegration } from '@sentry-internal/feedback-modal';
5+
import { feedbackScreenshotIntegration } from '@sentry-internal/feedback-screenshot';
36
import {
47
addTracingExtensionsShim,
58
browserTracingIntegrationShim,
@@ -12,6 +15,8 @@ export {
1215
addTracingExtensionsShim as addTracingExtensions,
1316
replayIntegrationShim as replayIntegration,
1417
feedbackIntegration,
18+
feedbackModalIntegration,
19+
feedbackScreenshotIntegration,
1520
getFeedback,
1621
};
1722
// Note: We do not export a shim for `Span` here, as that is quite complex and would blow up the bundle

packages/browser/src/index.bundle.replay.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import {
33
addTracingExtensionsShim,
44
browserTracingIntegrationShim,
55
feedbackIntegrationShim,
6+
feedbackModalIntegrationShim,
7+
feedbackScreenshotIntegrationShim,
68
} from '@sentry-internal/integration-shims';
79
import { replayIntegration } from '@sentry-internal/replay';
810

@@ -12,5 +14,7 @@ export {
1214
addTracingExtensionsShim as addTracingExtensions,
1315
replayIntegration,
1416
feedbackIntegrationShim as feedbackIntegration,
17+
feedbackModalIntegrationShim as feedbackModalIntegration,
18+
feedbackScreenshotIntegrationShim as feedbackScreenshotIntegration,
1519
};
1620
// Note: We do not export a shim for `Span` here, as that is quite complex and would blow up the bundle

packages/browser/src/index.bundle.tracing.replay.feedback.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import { feedbackIntegration, getFeedback } from '@sentry-internal/feedback';
2+
import { feedbackModalIntegration } from '@sentry-internal/feedback-modal';
3+
import { feedbackScreenshotIntegration } from '@sentry-internal/feedback-screenshot';
24
import { replayIntegration } from '@sentry-internal/replay';
35
import {
46
browserTracingIntegration,
@@ -22,6 +24,8 @@ export {
2224

2325
export {
2426
feedbackIntegration,
27+
feedbackModalIntegration,
28+
feedbackScreenshotIntegration,
2529
replayIntegration,
2630
browserTracingIntegration,
2731
addTracingExtensions,

packages/browser/src/index.bundle.tracing.replay.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
import { feedbackIntegrationShim } from '@sentry-internal/integration-shims';
1+
import {
2+
feedbackIntegrationShim,
3+
feedbackModalIntegrationShim,
4+
feedbackScreenshotIntegrationShim,
5+
} from '@sentry-internal/integration-shims';
26
import { replayIntegration } from '@sentry-internal/replay';
37
import {
48
browserTracingIntegration,
@@ -23,6 +27,8 @@ export {
2327
export {
2428
replayIntegration,
2529
feedbackIntegrationShim as feedbackIntegration,
30+
feedbackModalIntegrationShim as feedbackModalIntegration,
31+
feedbackScreenshotIntegrationShim as feedbackScreenshotIntegration,
2632
browserTracingIntegration,
2733
addTracingExtensions,
2834
startBrowserTracingNavigationSpan,

packages/browser/src/index.bundle.tracing.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
// This is exported so the loader does not fail when switching off Replay
2-
import { feedbackIntegrationShim, replayIntegrationShim } from '@sentry-internal/integration-shims';
2+
import {
3+
feedbackIntegrationShim,
4+
feedbackModalIntegrationShim,
5+
feedbackScreenshotIntegrationShim,
6+
replayIntegrationShim,
7+
} from '@sentry-internal/integration-shims';
38
import {
49
browserTracingIntegration,
510
startBrowserTracingNavigationSpan,
@@ -22,6 +27,8 @@ export {
2227

2328
export {
2429
feedbackIntegrationShim as feedbackIntegration,
30+
feedbackModalIntegrationShim as feedbackModalIntegration,
31+
feedbackScreenshotIntegrationShim as feedbackScreenshotIntegration,
2532
replayIntegrationShim as replayIntegration,
2633
browserTracingIntegration,
2734
addTracingExtensions,

0 commit comments

Comments
 (0)