Skip to content

Commit a9e6ba8

Browse files
authored
fix(node): Add origin to redis span (#12201)
Noticed we forgot to set this.
1 parent a87af78 commit a9e6ba8

File tree

3 files changed

+12
-0
lines changed
  • dev-packages/node-integration-tests/suites/tracing
  • packages/node/src/integrations/tracing

3 files changed

+12
-0
lines changed

dev-packages/node-integration-tests/suites/tracing/redis-cache/test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ describe('redis auto instrumentation', () => {
1212
expect.objectContaining({
1313
description: 'set test-key [1 other arguments]',
1414
op: 'db',
15+
origin: 'auto.db.otel.redis',
1516
data: expect.objectContaining({
1617
'sentry.op': 'db',
1718
'db.system': 'redis',
@@ -23,6 +24,7 @@ describe('redis auto instrumentation', () => {
2324
expect.objectContaining({
2425
description: 'get test-key',
2526
op: 'db',
27+
origin: 'auto.db.otel.redis',
2628
data: expect.objectContaining({
2729
'sentry.op': 'db',
2830
'db.system': 'redis',
@@ -48,6 +50,7 @@ describe('redis auto instrumentation', () => {
4850
expect.objectContaining({
4951
description: 'set ioredis-cache:test-key [1 other arguments]',
5052
op: 'cache.put',
53+
origin: 'auto.db.otel.redis',
5154
data: expect.objectContaining({
5255
'db.statement': 'set ioredis-cache:test-key [1 other arguments]',
5356
'cache.key': 'ioredis-cache:test-key',
@@ -60,6 +63,7 @@ describe('redis auto instrumentation', () => {
6063
expect.objectContaining({
6164
description: 'get ioredis-cache:test-key',
6265
op: 'cache.get_item', // todo: will be changed to cache.get
66+
origin: 'auto.db.otel.redis',
6367
data: expect.objectContaining({
6468
'db.statement': 'get ioredis-cache:test-key',
6569
'cache.hit': true,
@@ -73,6 +77,7 @@ describe('redis auto instrumentation', () => {
7377
expect.objectContaining({
7478
description: 'get ioredis-cache:unavailable-data',
7579
op: 'cache.get_item', // todo: will be changed to cache.get
80+
origin: 'auto.db.otel.redis',
7681
data: expect.objectContaining({
7782
'db.statement': 'get ioredis-cache:unavailable-data',
7883
'cache.hit': false,

dev-packages/node-integration-tests/suites/tracing/redis/test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,10 @@ describe('redis auto instrumentation', () => {
1212
expect.objectContaining({
1313
description: 'set test-key [1 other arguments]',
1414
op: 'db',
15+
origin: 'auto.db.otel.redis',
1516
data: expect.objectContaining({
1617
'sentry.op': 'db',
18+
'sentry.origin': 'auto.db.otel.redis',
1719
'db.system': 'redis',
1820
'net.peer.name': 'localhost',
1921
'net.peer.port': 6379,
@@ -23,8 +25,10 @@ describe('redis auto instrumentation', () => {
2325
expect.objectContaining({
2426
description: 'get test-key',
2527
op: 'db',
28+
origin: 'auto.db.otel.redis',
2629
data: expect.objectContaining({
2730
'sentry.op': 'db',
31+
'sentry.origin': 'auto.db.otel.redis',
2832
'db.system': 'redis',
2933
'net.peer.name': 'localhost',
3034
'net.peer.port': 6379,

packages/node/src/integrations/tracing/redis.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {
44
SEMANTIC_ATTRIBUTE_CACHE_ITEM_SIZE,
55
SEMANTIC_ATTRIBUTE_CACHE_KEY,
66
SEMANTIC_ATTRIBUTE_SENTRY_OP,
7+
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
78
defineIntegration,
89
spanToJSON,
910
} from '@sentry/core';
@@ -49,6 +50,8 @@ const _redisIntegration = ((options?: RedisOptions) => {
4950
responseHook: (span, redisCommand, cmdArgs, response) => {
5051
const key = cmdArgs[0];
5152

53+
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.redis');
54+
5255
if (!options?.cachePrefixes || !shouldConsiderForCache(redisCommand, key, options.cachePrefixes)) {
5356
// not relevant for cache
5457
return;

0 commit comments

Comments
 (0)