Skip to content

Commit 99d0bda

Browse files
committed
fix & increase size limit
1 parent ee697be commit 99d0bda

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

.size-limit.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ module.exports = [
180180
name: 'CDN Bundle (incl. Tracing, Replay)',
181181
path: createCDNPath('bundle.tracing.replay.min.js'),
182182
gzip: true,
183-
limit: '73 KB',
183+
limit: '74 KB',
184184
},
185185
{
186186
name: 'CDN Bundle (incl. Tracing, Replay, Feedback)',

dev-packages/browser-integration-tests/suites/replay/dsc/test.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,6 +227,8 @@ sentryTest('should add replay_id to error DSC while replay is active', async ({
227227
sentryTest.skip();
228228
}
229229

230+
const hasTracing = !shouldSkipTracingTest();
231+
230232
await page.route('https://dsn.ingest.sentry.io/**/*', route => {
231233
return route.fulfill({
232234
status: 200,
@@ -242,7 +244,7 @@ sentryTest('should add replay_id to error DSC while replay is active', async ({
242244
const error2Req = waitForErrorRequest(page, event => event.exception?.values?.[0].value === 'This is error #2');
243245

244246
// We want to wait for the transaction to be done, to ensure we have a consistent test
245-
const transactionReq = shouldSkipTracingTest() ? Promise.resolve() : waitForTransactionRequest(page);
247+
const transactionReq = hasTracing ? waitForTransactionRequest(page) : Promise.resolve();
246248

247249
// Wait for this to be available
248250
await page.waitForFunction('!!window.Replay');
@@ -262,11 +264,15 @@ sentryTest('should add replay_id to error DSC while replay is active', async ({
262264
expect(error1Header.trace).toBeDefined();
263265
expect(error1Header.trace).toEqual({
264266
environment: 'production',
265-
sample_rate: '1',
266267
trace_id: expect.any(String),
267268
public_key: 'public',
268269
replay_id: replay.session?.id,
269-
sampled: 'true',
270+
...(hasTracing
271+
? {
272+
sample_rate: '1',
273+
sampled: 'true',
274+
}
275+
: {}),
270276
});
271277

272278
// Now end replay and trigger another error, it should not have a replay_id in DSC anymore

0 commit comments

Comments
 (0)