change EventBufferProxy types back

Author: billyvg

packages/replay-internal/src/eventBuffer/EventBufferArray.ts

@@ -14,12 +14,16 @@ export class EventBufferArray implements EventBuffer {
   /** @inheritdoc */
   public hasCheckout: boolean;
 
+  /** @inheritdoc */
+  public waitForCheckout: boolean;
+
   private _totalSize: number;
 
   public constructor() {
     this.events = [];
     this._totalSize = 0;
     this.hasCheckout = false;
+    this.waitForCheckout = false;
   }
 
   /** @inheritdoc */

packages/replay-internal/src/eventBuffer/EventBufferCompressionWorker.ts

@@ -16,6 +16,9 @@ export class EventBufferCompressionWorker implements EventBuffer {
   /** @inheritdoc */
   public hasCheckout: boolean;
 
+  /** @inheritdoc */
+  public waitForCheckout: boolean;
+
   private _worker: WorkerHandler;
   private _earliestTimestamp: number | null;
   private _totalSize;
@@ -25,6 +28,7 @@ export class EventBufferCompressionWorker implements EventBuffer {
     this._earliestTimestamp = null;
     this._totalSize = 0;
     this.hasCheckout = false;
+    this.waitForCheckout = false;
   }
 
   /** @inheritdoc */

packages/replay-internal/src/eventBuffer/EventBufferProxy.ts

@@ -12,12 +12,6 @@ import { EventBufferCompressionWorker } from './EventBufferCompressionWorker';
  * Exported only for testing.
  */
 export class EventBufferProxy implements EventBuffer {
-  /**
-   * If the event buffer needs to wait for a checkout event before it
-   * starts buffering events.
-   */
-  public waitForCheckout: boolean;
-
   private _fallback: EventBufferArray;
   private _compression: EventBufferCompressionWorker;
   private _used: EventBuffer;
@@ -29,7 +23,11 @@ export class EventBufferProxy implements EventBuffer {
     this._used = this._fallback;
 
     this._ensureWorkerIsLoadedPromise = this._ensureWorkerIsLoaded();
-    this.waitForCheckout = false;
+  }
+
+  /** @inheritdoc */
+  public get waitForCheckout(): boolean {
+    return this._used.waitForCheckout;
   }
 
   /** @inheritdoc */

packages/replay-internal/src/eventBuffer/index.ts

@@ -1,5 +1,6 @@
 import { getWorkerURL } from '@sentry-internal/replay-worker';
 
+import type { EventBuffer } from '../types';
 import { DEBUG_BUILD } from '../debug-build';
 import { logger } from '../util/logger';
 import { EventBufferArray } from './EventBufferArray';
@@ -19,7 +20,7 @@ declare const __SENTRY_EXCLUDE_REPLAY_WORKER__: boolean;
 export function createEventBuffer({
   useCompression,
   workerUrl: customWorkerUrl,
-}: CreateEventBufferParams): EventBufferProxy {
+}: CreateEventBufferParams): EventBuffer {
   if (
     useCompression &&
     // eslint-disable-next-line no-restricted-globals

packages/replay-internal/src/replay.ts

@@ -27,6 +27,7 @@ import type {
   AddUpdateCallback,
   AllPerformanceEntry,
   AllPerformanceEntryData,
+  EventBuffer,
   InternalEventContext,
   PopEventContext,
   RecordingEvent,
@@ -57,13 +58,12 @@ import { sendReplay } from './util/sendReplay';
 import { RateLimitError } from './util/sendReplayRequest';
 import type { SKIPPED } from './util/throttle';
 import { THROTTLED, throttle } from './util/throttle';
-import type { EventBufferProxy } from './eventBuffer/EventBufferProxy';
 
 /**
  * The main replay container class, which holds all the state and methods for recording and sending replays.
  */
 export class ReplayContainer implements ReplayContainerInterface {
-  public eventBuffer: EventBufferProxy | null;
+  public eventBuffer: EventBuffer | null;
 
   public performanceEntries: AllPerformanceEntry[];
 

packages/replay-internal/src/types/replay.ts

@@ -9,7 +9,6 @@ import type {
   Span,
   XhrBreadcrumbHint,
 } from '@sentry/types';
-import type { EventBufferProxy } from '../eventBuffer/EventBufferProxy';
 
 import type { SKIPPED, THROTTLED } from '../util/throttle';
 import type { AllPerformanceEntry, AllPerformanceEntryData, ReplayPerformanceEntry } from './performance';
@@ -401,6 +400,12 @@ export interface EventBuffer {
    */
   hasCheckout: boolean;
 
+  /**
+   * If the event buffer needs to wait for a checkout event before it
+   * starts buffering events.
+   */
+  waitForCheckout: boolean;
+
   /**
    * Destroy the event buffer.
    */
@@ -450,7 +455,7 @@ export interface ReplayClickDetector {
 }
 
 export interface ReplayContainer {
-  eventBuffer: EventBufferProxy | null;
+  eventBuffer: EventBuffer | null;
   clickDetector: ReplayClickDetector | undefined;
   /**
    * List of PerformanceEntry from PerformanceObservers.