Skip to content

Commit 81e0fd1

Browse files
authored
build: Bump node to 18.20.3 (#12271)
I noticed that locally the node-integration-tests that check versions fail, because in the SDK we use 18.18.0, we only check for "If node.major >= 18", and then get an incorrect test because actually in code we check the minor too. Instead of adjust this, IMHO it's better to update this. This also never failed on CI because there we do use latest 18 for the matrix tests...
1 parent bf0a138 commit 81e0fd1

File tree

7 files changed

+8
-13
lines changed

7 files changed

+8
-13
lines changed

.size-limit.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ module.exports = [
149149
name: 'CDN Bundle (incl. Tracing, Replay)',
150150
path: createCDNPath('bundle.tracing.replay.min.js'),
151151
gzip: true,
152-
limit: '70 KB',
152+
limit: '72 KB',
153153
},
154154
{
155155
name: 'CDN Bundle (incl. Tracing, Replay, Feedback)',
@@ -170,7 +170,7 @@ module.exports = [
170170
path: createCDNPath('bundle.tracing.min.js'),
171171
gzip: false,
172172
brotli: false,
173-
limit: '105 KB',
173+
limit: '110 KB',
174174
},
175175
{
176176
name: 'CDN Bundle (incl. Tracing, Replay) - uncompressed',

dev-packages/e2e-tests/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@
2727
"yaml": "2.2.2"
2828
},
2929
"volta": {
30-
"node": "18.20.2",
31-
"yarn": "1.22.22",
30+
"extends": "../../package.json",
3231
"pnpm": "8.15.8"
3332
}
3433
}

dev-packages/e2e-tests/test-applications/node-express-cjs-preload/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"@playwright/test": "^1.27.1"
1919
},
2020
"volta": {
21-
"extends": "../../package.json",
22-
"node": "18.19.1"
21+
"extends": "../../package.json"
2322
}
2423
}

dev-packages/e2e-tests/test-applications/node-express-esm-loader/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"@playwright/test": "^1.27.1"
1919
},
2020
"volta": {
21-
"extends": "../../package.json",
22-
"node": "18.19.1"
21+
"extends": "../../package.json"
2322
}
2423
}

dev-packages/e2e-tests/test-applications/node-express-esm-preload/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"@playwright/test": "^1.27.1"
1919
},
2020
"volta": {
21-
"extends": "../../package.json",
22-
"node": "18.19.1"
21+
"extends": "../../package.json"
2322
}
2423
}

dev-packages/e2e-tests/test-applications/node-express-esm-without-loader/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
"@playwright/test": "^1.27.1"
1919
},
2020
"volta": {
21-
"extends": "../../package.json",
22-
"node": "18.19.1"
21+
"extends": "../../package.json"
2322
}
2423
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
"yalc:publish": "lerna run yalc:publish"
4242
},
4343
"volta": {
44-
"node": "18.18.0",
44+
"node": "18.20.3",
4545
"yarn": "1.22.19"
4646
},
4747
"workspaces": [

0 commit comments

Comments
 (0)