refactor(tanstackstart-react): Remove passthrough ErrorBoundary from server and cloudflare entries

ErrorBoundary is a React client rendering concept that does not function
during SSR. Exporting a no-op passthrough from server entries is
semantically incorrect and may give users false confidence in error
handling. This aligns with the React Router package which does not
export ErrorBoundary from its server entry point.

The cloudflare entry now re-exports the real @sentry/react ErrorBoundary
via `export * from '../client'` instead of overriding it with a
passthrough.

Author: smorimoto

packages/tanstackstart-react/src/cloudflare/index.ts

@@ -7,30 +7,3 @@ export * from '../common';
 export { wrapFetchWithSentry } from '../server/wrapFetchWithSentry';
 export { wrapMiddlewaresWithSentry } from '../server/middleware';
 export { sentryGlobalRequestMiddleware, sentryGlobalFunctionMiddleware } from '../server/globalMiddleware';
-
-/**
- * A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
- * so they should simply be a passthrough.
- */
-export const ErrorBoundary = (props: React.PropsWithChildren<unknown>): React.ReactNode => {
-  if (!props.children) {
-    return null;
-  }
-
-  if (typeof props.children === 'function') {
-    return (props.children as () => React.ReactNode)();
-  }
-
-  return props.children;
-};
-
-/**
- * A passthrough error boundary wrapper for the server that doesn't depend on any react. Error boundaries don't catch
- * SSR errors so they should simply be a passthrough.
- */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function withErrorBoundary<P extends Record<string, any>>(
-  WrappedComponent: React.ComponentType<P>,
-): React.FC<P> {
-  return WrappedComponent as React.FC<P>;
-}

packages/tanstackstart-react/src/index.types.ts

@@ -22,9 +22,6 @@ export declare const contextLinesIntegration: typeof clientSdk.contextLinesInteg
 export declare const getDefaultIntegrations: (options: Options) => Integration[];
 export declare const defaultStackParser: StackParser;
 
-export declare const ErrorBoundary: typeof clientSdk.ErrorBoundary;
-export declare const withErrorBoundary: typeof clientSdk.withErrorBoundary;
-
 export declare const logger: typeof clientSdk.logger | typeof serverSdk.logger;
 
 export declare const growthbookIntegration: typeof clientSdk.growthbookIntegration;

packages/tanstackstart-react/src/server/index.ts

@@ -23,30 +23,3 @@ export function tanstackRouterBrowserTracingIntegration(
     setup() {},
   };
 }
-
-/**
- * A passthrough error boundary for the server that doesn't depend on any react. Error boundaries don't catch SSR errors
- * so they should simply be a passthrough.
- */
-export const ErrorBoundary = (props: React.PropsWithChildren<unknown>): React.ReactNode => {
-  if (!props.children) {
-    return null;
-  }
-
-  if (typeof props.children === 'function') {
-    return (props.children as () => React.ReactNode)();
-  }
-
-  return props.children;
-};
-
-/**
- * A passthrough error boundary wrapper for the server that doesn't depend on any react. Error boundaries don't catch
- * SSR errors so they should simply be a passthrough.
- */
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-export function withErrorBoundary<P extends Record<string, any>>(
-  WrappedComponent: React.ComponentType<P>,
-): React.FC<P> {
-  return WrappedComponent as React.FC<P>;
-}

packages/tanstackstart-react/test/cloudflare/index.test.ts

@@ -1,3 +1,4 @@
+import { ErrorBoundary as ReactErrorBoundary, withErrorBoundary as reactWithErrorBoundary } from '@sentry/react';
 import { describe, expect, it } from 'vitest';
 import * as CloudflareExports from '../../src/cloudflare/index';
 
@@ -29,32 +30,13 @@ describe('Cloudflare entrypoint', () => {
     it('exports wrapFetchWithSentry', () => {
       expect(typeof CloudflareExports.wrapFetchWithSentry).toBe('function');
     });
-  });
-
-  describe('ErrorBoundary', () => {
-    it('is a passthrough that returns children directly', () => {
-      const children = 'test child';
-      const result = CloudflareExports.ErrorBoundary({ children });
-      expect(result).toBe('test child');
-    });
 
-    it('returns null when no children are provided', () => {
-      const result = CloudflareExports.ErrorBoundary({});
-      expect(result).toBeNull();
+    it('exports ErrorBoundary from @sentry/react', () => {
+      expect(CloudflareExports.ErrorBoundary).toBe(ReactErrorBoundary);
     });
 
-    it('calls children when children is a function', () => {
-      const children = () => 'function result';
-      const result = CloudflareExports.ErrorBoundary({ children });
-      expect(result).toBe('function result');
-    });
-  });
-
-  describe('withErrorBoundary', () => {
-    it('is a passthrough that returns the original component', () => {
-      const MockComponent = () => null;
-      const result = CloudflareExports.withErrorBoundary(MockComponent);
-      expect(result).toBe(MockComponent);
+    it('exports withErrorBoundary from @sentry/react', () => {
+      expect(CloudflareExports.withErrorBoundary).toBe(reactWithErrorBoundary);
     });
   });
 });