Skip to content

Commit 7819140

Browse files
authored
feat(core)!: Remove TransactionNamingScheme type (#14865)
ref: #14268 Deprecation PR: #14405 Removes `TransactionNamingScheme`. This has no replacement.
1 parent 4e6c7cb commit 7819140

File tree

3 files changed

+3
-11
lines changed

3 files changed

+3
-11
lines changed

docs/migration/v8-to-v9.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ Sentry.init({
142142
- The `urlEncode` method has been removed. There is no replacement.
143143
- The `getDomElement` method has been removed. There is no replacement.
144144
- The `Request` type has been removed. Use `RequestEventData` type instead.
145+
- The `TransactionNamingScheme` type has been removed. There is no replacement.
145146
- The `memoBuilder` method has been removed. There is no replacement.
146147

147148
### `@sentry/browser`

packages/core/src/utils-hoist/index.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,7 @@ export {
8080
extractQueryParamsFromUrl,
8181
headersToDict,
8282
} from './requestdata';
83-
export type {
84-
AddRequestDataToEventOptions,
85-
// eslint-disable-next-line deprecation/deprecation
86-
TransactionNamingScheme,
87-
} from './requestdata';
83+
export type { AddRequestDataToEventOptions } from './requestdata';
8884

8985
export { severityLevelFromString } from './severity';
9086
export {

packages/core/src/utils-hoist/requestdata.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export type AddRequestDataToEventOptions = {
3737
request?: boolean | Array<(typeof DEFAULT_REQUEST_INCLUDES)[number]>;
3838
/** @deprecated This option will be removed in v9. It does not do anything anymore, the `transcation` is set in other places. */
3939
// eslint-disable-next-line deprecation/deprecation
40-
transaction?: boolean | TransactionNamingScheme;
40+
transaction?: boolean | 'path' | 'methodPath' | 'handler';
4141
user?: boolean | Array<(typeof DEFAULT_USER_INCLUDES)[number]>;
4242
};
4343

@@ -54,11 +54,6 @@ export type AddRequestDataToEventOptions = {
5454
};
5555
};
5656

57-
/**
58-
* @deprecated This type will be removed in v9. It is not in use anymore.
59-
*/
60-
export type TransactionNamingScheme = 'path' | 'methodPath' | 'handler';
61-
6257
/**
6358
* Extracts a complete and parameterized path from the request object and uses it to construct transaction name.
6459
* If the parameterized transaction name cannot be extracted, we fall back to the raw URL.

0 commit comments

Comments
 (0)