Skip to content

Commit 76c8191

Browse files
committed
remove browser functionality due to CORS
1 parent 83ec806 commit 76c8191

File tree

7 files changed

+2
-81
lines changed

7 files changed

+2
-81
lines changed

dev-packages/browser-integration-tests/suites/transport/userAgent/init.js

Lines changed: 0 additions & 12 deletions
This file was deleted.

dev-packages/browser-integration-tests/suites/transport/userAgent/subject.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

dev-packages/browser-integration-tests/suites/transport/userAgent/test.ts

Lines changed: 0 additions & 32 deletions
This file was deleted.

packages/browser/src/client.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
_INTERNAL_flushLogsBuffer,
1414
_INTERNAL_flushMetricsBuffer,
1515
addAutoIpAddressToSession,
16-
addUserAgentToTransportHeaders,
1716
applySdkMetadata,
1817
Client,
1918
getSDKSource,
@@ -94,8 +93,6 @@ export class BrowserClient extends Client<BrowserClientOptions> {
9493
const sdkSource = WINDOW.SENTRY_SDK_SOURCE || getSDKSource();
9594
applySdkMetadata(opts, 'browser', ['browser'], sdkSource);
9695

97-
addUserAgentToTransportHeaders(opts, 'X-Sentry-User-Agent');
98-
9996
// Only allow IP inferral by Relay if sendDefaultPii is true
10097
if (opts._metadata?.sdk) {
10198
opts._metadata.sdk.settings = {

packages/browser/test/client.test.ts

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -235,33 +235,3 @@ describe('SDK metadata', () => {
235235
});
236236
});
237237
});
238-
239-
describe('user agent header', () => {
240-
it('adds X-Sentry-User-Agent header to transport options', () => {
241-
const options = getDefaultBrowserClientOptions({});
242-
const client = new BrowserClient(options);
243-
244-
expect(client.getOptions().transportOptions?.headers).toEqual({
245-
'X-Sentry-User-Agent': `sentry.javascript.browser/${SDK_VERSION}`,
246-
});
247-
});
248-
249-
it('respects user-passed headers', () => {
250-
const options = getDefaultBrowserClientOptions({
251-
transportOptions: {
252-
headers: {
253-
'x-custom-header': 'custom-value',
254-
'X-Sentry-User-Agent': 'custom-user-agent',
255-
'user-agent': 'custom-user-agent-2',
256-
},
257-
},
258-
});
259-
const client = new BrowserClient(options);
260-
261-
expect(client.getOptions().transportOptions?.headers).toEqual({
262-
'x-custom-header': 'custom-value',
263-
'X-Sentry-User-Agent': 'custom-user-agent',
264-
'user-agent': 'custom-user-agent-2',
265-
});
266-
});
267-
});

packages/core/src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ export type { ClientClass as SentryCoreCurrentScopes } from './sdk';
44
export type { AsyncContextStrategy } from './asyncContext/types';
55
export type { Carrier } from './carrier';
66
export type { OfflineStore, OfflineTransportOptions } from './transports/offline';
7-
export { addUserAgentToTransportHeaders } from './transports/userAgent';
87
export type { ServerRuntimeClientOptions } from './server-runtime-client';
98
export type { IntegrationIndex } from './integration';
109

packages/core/src/transports/userAgent.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ import type { ClientOptions } from '../types-hoist/options';
77
*
88
* @see https://develop.sentry.dev/sdk/overview/#user-agent
99
*/
10-
export function addUserAgentToTransportHeaders(options: ClientOptions, userAgentHeaderName = 'user-agent'): void {
10+
export function addUserAgentToTransportHeaders(options: ClientOptions): void {
1111
const sdkMetadata = options._metadata?.sdk;
1212
const sdkUserAgent =
1313
sdkMetadata?.name && sdkMetadata?.version ? `${sdkMetadata?.name}/${sdkMetadata?.version}` : undefined;
1414

1515
options.transportOptions = {
1616
...options.transportOptions,
1717
headers: {
18-
...(sdkUserAgent && { [userAgentHeaderName]: sdkUserAgent }),
18+
...(sdkUserAgent && { 'user-agent': sdkUserAgent }),
1919
...options.transportOptions?.headers,
2020
},
2121
};

0 commit comments

Comments
 (0)