Skip to content

Commit 524fb6e

Browse files
authored
fix(ember): Speed up ember scenarios (#5532)
It is running the scenarios in sequence, running them in parallel might speed up the builds a bit.
1 parent c7550dd commit 524fb6e

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

.github/workflows/build.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,9 @@ jobs:
380380
continue-on-error: true
381381
timeout-minutes: 30
382382
runs-on: ubuntu-latest
383+
strategy:
384+
matrix:
385+
scenario: [ember-release, ember-beta, ember-classic, ember-lts-3.24]
383386
steps:
384387
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
385388
uses: actions/checkout@v2
@@ -409,7 +412,9 @@ jobs:
409412
path: ${{ env.CACHED_BUILD_PATHS }}
410413
key: ${{ env.BUILD_CACHE_KEY }}
411414
- name: Run Ember tests
412-
run: yarn test --scope=@sentry/ember
415+
run: |
416+
cd packages/ember
417+
yarn ember try:one ${{ matrix.scenario }} --skip-cleanup=true
413418
- name: Compute test coverage
414419
uses: codecov/codecov-action@v1
415420

packages/ember/config/ember-try.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,6 @@ module.exports = async function () {
3636
},
3737
embroiderSafe(),
3838
]);
39-
}
40-
41-
// finally, just to be extra thorough when merging to master and releasing, we add the beta channel and ember
42-
// "classic" (a legacy version which was last current in late 2019)
43-
if (
44-
process.env.GITHUB_EVENT_NAME === 'push' &&
45-
(process.env.GITHUB_HEAD_REF === 'master' || process.env.GITHUB_HEAD_REF.startsWith('release'))
46-
) {
4739
scenarios = scenarios.concat([
4840
{
4941
name: 'ember-beta',

0 commit comments

Comments
 (0)