Skip to content

Commit 4ab2609

Browse files
committed
Handle variadic arguments to logDebug
This lets us do fancier logging such as: ``` logDebug('debug', {}, 'foo', true); ```
1 parent d36977e commit 4ab2609

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

.jshintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
"browser": true,
55
"predef": [
66
"TraceKit",
7-
"console"
7+
"console",
8+
"_slice"
89
]
910
}

src/raven.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -850,9 +850,11 @@ function uuid4() {
850850
}
851851
}
852852

853-
function logDebug(level, message) {
853+
function logDebug(level) {
854854
if (window.console && console[level] && Raven.debug) {
855-
console[level](message);
855+
// _slice is coming from vendor/TraceKit/tracekit.js
856+
// so it's accessible globally
857+
console[level].apply(console, _slice.call(arguments, 1));
856858
}
857859
}
858860

test/raven.test.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,13 @@ describe('globals', function() {
322322
logDebug(level, message);
323323
assert.isTrue(console[level].calledOnce);
324324
});
325+
326+
it('should handle variadic arguments', function() {
327+
Raven.debug = true;
328+
this.sinon.stub(console, level);
329+
logDebug(level, message, {}, 'foo');
330+
assert.isTrue(console[level].calledOnce);
331+
});
325332
});
326333

327334
describe('setAuthQueryString', function() {

0 commit comments

Comments
 (0)