Skip to content

Commit 3ef0b80

Browse files
committed
remove name from transaction change interface
1 parent 8c00b71 commit 3ef0b80

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

packages/tracing/src/transaction.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
7474
this._name = newName;
7575
const source = 'custom';
7676
this.metadata.source = source;
77-
this.metadata.nameChanges.push(generateTransactionNameChange(newName, source, this.metadata.numPropagations));
77+
this.metadata.nameChanges.push(generateTransactionNameChange(source, this.metadata.numPropagations));
7878
}
7979

8080
/**
@@ -83,7 +83,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
8383
public setName(name: string, source: TransactionMetadata['source'] = 'custom'): void {
8484
this.name = name;
8585
this.metadata.source = source;
86-
this.metadata.nameChanges.push(generateTransactionNameChange(name, source, this.metadata.numPropagations));
86+
this.metadata.nameChanges.push(generateTransactionNameChange(source, this.metadata.numPropagations));
8787
}
8888

8989
/**
@@ -291,13 +291,8 @@ export class Transaction extends SpanClass implements TransactionInterface {
291291
}
292292

293293
/** Generate objects representing a transaction name change */
294-
export function generateTransactionNameChange(
295-
name: string,
296-
source: TransactionSource,
297-
propagations: number,
298-
): TransactionNameChange {
294+
export function generateTransactionNameChange(source: TransactionSource, propagations: number): TransactionNameChange {
299295
return {
300-
name,
301296
source,
302297
timestamp: timestampWithMs(),
303298
propagations,

packages/types/src/transaction.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,6 @@ export type TransactionSource =
180180
* Object representing metadata about when a transaction name was changed.
181181
*/
182182
export interface TransactionNameChange {
183-
// new name
184-
name: string;
185183
// unix timestamp when the name was changed
186184
timestamp: number;
187185
// new source

0 commit comments

Comments
 (0)