Skip to content

Commit 345d4d5

Browse files
authored
Merge pull request #12473 from getsentry/prepare-release/8.9.2
meta(changelog): Update changelog for 8.9.2
2 parents b85398c + 024f5ea commit 345d4d5

File tree

6 files changed

+13
-6
lines changed

6 files changed

+13
-6
lines changed

.craft.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,8 @@ targets:
184184
onlyIfPresent: /^sentry-nextjs-\d.*\.tgz$/
185185
'npm:@sentry/remix':
186186
onlyIfPresent: /^sentry-remix-\d.*\.tgz$/
187+
'npm:@sentry/solid':
188+
onlyIfPresent: /^sentry-solid-\d.*\.tgz$/
187189
'npm:@sentry/svelte':
188190
onlyIfPresent: /^sentry-svelte-\d.*\.tgz$/
189191
'npm:@sentry/sveltekit':

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
66

7+
## 8.9.2
8+
9+
- fix(profiling): Update exports so types generate properly (#12469)
10+
711
## 8.9.1
812

913
### Important changes

dev-packages/e2e-tests/test-applications/solid/tests/errorboundary.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { waitForError } from '@sentry-internal/test-utils';
33

44
test('captures an exception', async ({ page }) => {
55
const errorEventPromise = waitForError('solid', errorEvent => {
6-
return !errorEvent.type;
6+
return !errorEvent.type && errorEvent.transaction === '/error-boundary-example';
77
});
88

99
const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);
@@ -27,7 +27,7 @@ test('captures an exception', async ({ page }) => {
2727

2828
test('captures a second exception after resetting the boundary', async ({ page }) => {
2929
const firstErrorEventPromise = waitForError('solid', errorEvent => {
30-
return !errorEvent.type;
30+
return !errorEvent.type && errorEvent.transaction === '/error-boundary-example';
3131
});
3232

3333
const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);
@@ -49,7 +49,7 @@ test('captures a second exception after resetting the boundary', async ({ page }
4949
});
5050

5151
const secondErrorEventPromise = waitForError('solid', errorEvent => {
52-
return !errorEvent.type;
52+
return !errorEvent.type && errorEvent.transaction === '/error-boundary-example';
5353
});
5454

5555
const [, secondErrorEvent] = await Promise.all([

dev-packages/e2e-tests/test-applications/solid/tests/errors.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { waitForError } from '@sentry-internal/test-utils';
33

44
test('sends an error', async ({ page }) => {
55
const errorPromise = waitForError('solid', async errorEvent => {
6-
return !errorEvent.type;
6+
return !errorEvent.type && errorEvent.transaction === '/';
77
});
88

99
await Promise.all([page.goto(`/`), page.locator('#errorBtn').click()]);

packages/profiling-node/src/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import * as os from 'os';
33
import type {
44
Client,
55
Context,
6+
ContinuousThreadCpuProfile,
67
DebugImage,
78
DsnComponents,
89
Envelope,
@@ -11,6 +12,7 @@ import type {
1112
Profile,
1213
ProfileChunk,
1314
ProfileChunkEnvelope,
15+
ProfileChunkItem,
1416
SdkInfo,
1517
StackFrame,
1618
StackParser,
@@ -21,8 +23,6 @@ import { GLOBAL_OBJ, createEnvelope, dsnToString, forEachEnvelopeItem, logger, u
2123
import { env, versions } from 'process';
2224
import { isMainThread, threadId } from 'worker_threads';
2325

24-
import type { ProfileChunkItem } from '@sentry/types/build/types/envelope';
25-
import type { ContinuousThreadCpuProfile } from '../../types/src/profiling';
2626
import { DEBUG_BUILD } from './debug-build';
2727
import type { RawChunkCpuProfile, RawThreadCpuProfile } from './types';
2828

packages/types/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ export type {
4646
StatsdEnvelope,
4747
ProfileItem,
4848
ProfileChunkEnvelope,
49+
ProfileChunkItem,
4950
SpanEnvelope,
5051
SpanItem,
5152
} from './envelope';

0 commit comments

Comments
 (0)