Skip to content

Commit 2f88a5f

Browse files
authored
chore: Resolve or postpone a random assortment of TODOs (#11977)
1 parent 9bbdfe7 commit 2f88a5f

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

packages/nextjs/src/common/withServerActionInstrumentation.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import { escapeNextjsTracing } from './utils/tracingUtils';
1515

1616
interface Options {
1717
formData?: FormData;
18-
// TODO(v8): Whenever we decide to drop support for Next.js <= 12 we can automatically pick up the headers becauase "next/headers" will be resolvable.
1918
headers?: Headers;
2019
recordResponse?: boolean;
2120
}

packages/nextjs/test/integration/test/client/tracingFetch.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { expect, test } from '@playwright/test';
2-
import { SerializedEvent } from '@sentry/types';
2+
import { Event } from '@sentry/types';
33
import { countEnvelopes, getMultipleSentryEnvelopeRequests } from './utils/helpers';
44

55
test('should correctly instrument `fetch` for performance tracing', async ({ page }) => {
@@ -12,7 +12,7 @@ test('should correctly instrument `fetch` for performance tracing', async ({ pag
1212
});
1313
});
1414

15-
const transaction = await getMultipleSentryEnvelopeRequests<SerializedEvent>(page, 1, {
15+
const transaction = await getMultipleSentryEnvelopeRequests<Event>(page, 1, {
1616
url: '/fetch',
1717
envelopeType: 'transaction',
1818
});

packages/node/src/transports/http.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export function makeNodeTransport(options: NodeTransportOptions): Transport {
7373
const nativeHttpModule = isHttps ? https : http;
7474
const keepAlive = options.keepAlive === undefined ? false : options.keepAlive;
7575

76-
// TODO(v7): Evaluate if we can set keepAlive to true. This would involve testing for memory leaks in older node
76+
// TODO(v9): Evaluate if we can set keepAlive to true. This would involve testing for memory leaks in older node
7777
// versions(>= 8) as they had memory leaks when using it: #2555
7878
const agent = proxy
7979
? (new HttpsProxyAgent(proxy) as http.Agent)

packages/types/src/envelope.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ type StatsdItemHeaders = { type: 'statsd'; length: number };
8383
type ProfileItemHeaders = { type: 'profile' };
8484
type SpanItemHeaders = { type: 'span' };
8585

86-
// TODO (v8): Replace `Event` with `SerializedEvent`
8786
export type EventItem = BaseEnvelopeItem<EventItemHeaders, Event>;
8887
export type AttachmentItem = BaseEnvelopeItem<AttachmentItemHeaders, string | Uint8Array>;
8988
export type UserFeedbackItem = BaseEnvelopeItem<UserFeedbackItemHeaders, UserFeedback>;

0 commit comments

Comments
 (0)