do not import window from browser pkg (circular import)

Author: billyvg

packages/feedback/src/constants.ts

@@ -1,3 +1,10 @@
+import { GLOBAL_OBJ } from "@sentry/utils";
+
+// exporting a separate copy of `WINDOW` rather than exporting the one from `@sentry/browser`
+// prevents the browser package from being bundled in the CDN bundle, and avoids a
+// circular dependency between the browser and replay packages
+export const WINDOW = GLOBAL_OBJ as typeof GLOBAL_OBJ & Window;
+
 const LIGHT_BACKGROUND = '#ffffff';
 const INHERIT = 'inherit';
 const SUBMIT_COLOR = 'rgba(108, 95, 199, 1)';

packages/feedback/src/integration.ts

@@ -1,4 +1,4 @@
-import { WINDOW } from '@sentry/browser';
+import { WINDOW } from './constants';
 import type { Integration } from '@sentry/types';
 import { isBrowser, logger } from '@sentry/utils';
 

packages/feedback/src/widget/Icon.ts

@@ -1,4 +1,4 @@
-import { WINDOW } from '@sentry/browser';
+import { WINDOW } from '../constants';
 
 import { setAttributesNS } from '../util/setAttributesNS';
 

packages/feedback/src/widget/Logo.ts

@@ -1,4 +1,4 @@
-import { WINDOW } from '@sentry/browser';
+import { WINDOW } from '../constants';
 
 import type { FeedbackInternalOptions } from '../types';
 import { setAttributesNS } from '../util/setAttributesNS';

packages/feedback/src/widget/SuccessIcon.ts

@@ -1,4 +1,4 @@
-import { WINDOW } from '@sentry/browser';
+import { WINDOW } from '../constants';
 
 import { setAttributesNS } from '../util/setAttributesNS';
 

packages/feedback/src/widget/createShadowHost.ts

@@ -1,4 +1,4 @@
-import { WINDOW } from '@sentry/browser';
+import { WINDOW } from '../constants';
 import { logger } from '@sentry/utils';
 
 import type { FeedbackInternalOptions } from '../types';

packages/feedback/src/widget/util/createElement.ts

@@ -1,4 +1,4 @@
-import { WINDOW } from '@sentry/browser';
+import { WINDOW } from '../../constants';
 
 /**
  * Helper function to create an element. Could be used as a JSX factory