Repository navigation
Commit 2a085be
fix(react-router): Pass the project when creating a release (#25089)
The release API rejects a release without a project, and the project
given to the `sentry` SDK does not reach `release.create`. Since the
move to that SDK (#23398), the Vite plugin logged `[Sentry] Could not
create release` on every build; the upload itself still ran, so builds
succeeded without a release. The unit test mocked the SDK, so it did not
catch it.
The plugin now passes the project it already has, as
`@sentry/bundler-plugins` does. Same bug in the Remix upload scripts,
fixed in #25079.
Refs #24989
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>1 parent 5fc18dc commit 2a085be
2 files changed
Lines changed: 7 additions & 3 deletions
File tree
- packages/react-router
- src/vite/buildEnd
- test/vite/buildEnd
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
| 70 | + | |
| 71 | + | |
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
89 | 92 | | |
90 | 93 | | |
91 | 94 | | |
| |||
115 | 118 | | |
116 | 119 | | |
117 | 120 | | |
118 | | - | |
| 121 | + | |
119 | 122 | | |
120 | 123 | | |
121 | 124 | | |
| |||
0 commit comments