Change ordering of plugins

Author: andreiborza

packages/solidstart/src/vite/sentrySolidStartVite.ts

@@ -9,13 +9,19 @@ import type { SentrySolidStartPluginOptions } from './types';
 export const sentrySolidStartVite = (options: SentrySolidStartPluginOptions = {}): Plugin[] => {
   const sentryPlugins: Plugin[] = [];
 
-  sentryPlugins.push(makeBuildInstrumentationFilePlugin(options));
-
   if (process.env.NODE_ENV !== 'development') {
     if (options.sourceMapsUploadOptions?.enabled ?? true) {
       sentryPlugins.push(...makeSourceMapsVitePlugin(options));
     }
   }
 
+  // TODO: Ensure this file is source mapped too.
+  // Placing this after the sentry vite plugin means this
+  // file won't get a sourcemap and won't have a debug id injected.
+  // Because the file is just copied over to the output server
+  // directory the release injection file from sentry vite plugin
+  // wouldn't resolve correctly otherwise.
+  sentryPlugins.push(makeBuildInstrumentationFilePlugin(options));
+
   return sentryPlugins;
 };

packages/solidstart/test/vite/sentrySolidStartVite.test.ts

@@ -23,14 +23,14 @@ describe('sentrySolidStartVite()', () => {
     const plugins = getSentrySolidStartVitePlugins();
     const names = plugins.map(plugin => plugin.name);
     expect(names).toEqual([
-      'sentry-solidstart-build-instrumentation-file',
       'sentry-solidstart-source-maps',
       'sentry-telemetry-plugin',
       'sentry-vite-release-injection-plugin',
       'sentry-debug-id-upload-plugin',
       'sentry-vite-debug-id-injection-plugin',
       'sentry-vite-debug-id-upload-plugin',
       'sentry-file-deletion-plugin',
+      'sentry-solidstart-build-instrumentation-file',
     ]);
   });