Skip to content

Commit 1b9d0f5

Browse files
committed
add name
1 parent 2a8d5c5 commit 1b9d0f5

File tree

3 files changed

+15
-12
lines changed

3 files changed

+15
-12
lines changed

packages/feedback/src/types/index.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,18 @@
11
import type { Event, Primitive } from '@sentry/types';
22

3+
export type SentryTags = { [key: string]: Primitive } | undefined;
4+
35
/**
46
* NOTE: These types are still considered Beta and subject to change.
57
* @hidden
68
*/
79
export interface FeedbackEvent extends Event {
810
feedback: {
9-
contact_email: string;
1011
message: string;
11-
replay_id: string | undefined;
1212
url: string;
13+
contact_email?: string;
14+
name?: string;
15+
replay_id?: string;
1316
};
1417
// TODO: Add this event type to Event
1518
// type: 'feedback_event';
@@ -18,10 +21,9 @@ export interface FeedbackEvent extends Event {
1821
export interface SendFeedbackData {
1922
feedback: {
2023
message: string;
21-
email: string;
22-
replay_id: string | undefined;
23-
name: string;
2424
url: string;
25+
email?: string;
26+
replay_id?: string;
27+
name?: string;
2528
};
26-
tags: { [key: string]: Primitive } | undefined;
2729
}

packages/feedback/src/util/prepareFeedbackEvent.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,19 @@ import type { Client } from '@sentry/types';
44

55
import type { FeedbackEvent } from '../types';
66

7+
interface PrepareFeedbackEventParams {
8+
client: Client;
9+
event: FeedbackEvent;
10+
scope: Scope;
11+
}
712
/**
813
* Prepare a feedback event & enrich it with the SDK metadata.
914
*/
1015
export async function prepareFeedbackEvent({
1116
client,
1217
scope,
1318
event,
14-
}: {
15-
client: Client;
16-
event: FeedbackEvent;
17-
scope: Scope;
18-
}): Promise<FeedbackEvent | null> {
19+
}: PrepareFeedbackEventParams): Promise<FeedbackEvent | null> {
1920
const eventHint = { integrations: undefined };
2021
if (client.emit) {
2122
client.emit('preprocessEvent', event, eventHint);

packages/feedback/src/util/sendFeedbackRequest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import { prepareFeedbackEvent } from './prepareFeedbackEvent';
99
*/
1010
export async function sendFeedbackRequest({
1111
feedback: { message, email, name, replay_id, url },
12-
tags,
1312
}: SendFeedbackData): Promise<Response | null> {
1413
const hub = getCurrentHub();
1514

@@ -29,6 +28,7 @@ export async function sendFeedbackRequest({
2928
const baseEvent = {
3029
feedback: {
3130
contact_email: email,
31+
name,
3232
message,
3333
replay_id,
3434
url,

0 commit comments

Comments
 (0)