make logic more clear

Author: AbhiPrasad

packages/core/src/tracing/idletransaction.ts

@@ -159,7 +159,12 @@ export class IdleTransaction extends Transaction {
         }
 
         const spanStartedBeforeTransactionFinish = span.startTimestamp < endTimestamp;
-        const spanEndedBeforeFinalTimeout = span.endTimestamp < (this._finalTimeout + this._idleTimeout) / 1000;
+
+        const timeoutWithDelta = (this._finalTimeout + this._idleTimeout) / 1000;
+
+        const transactionDidNotExceedTimeout = endTimestamp - this.startTimestamp < timeoutWithDelta;
+        const spanDidNotExceedTimeout = span.endTimestamp - span.startTimestamp < timeoutWithDelta;
+        const spanEndedBeforeFinalTimeout = transactionDidNotExceedTimeout && spanDidNotExceedTimeout;
 
         if (__DEBUG_BUILD__) {
           const stringifiedSpan = JSON.stringify(span, undefined, 2);

packages/tracing/test/idletransaction.test.ts

@@ -209,7 +209,7 @@ describe('IdleTransaction', () => {
     const span = transaction.startChild({ startTimestamp: transaction.startTimestamp + 2 });
     span.finish(span.startTimestamp + 10 + 30 + 1);
 
-    transaction.finish(transaction.startTimestamp + 10);
+    transaction.finish(transaction.startTimestamp + 50);
 
     expect(transaction.spanRecorder).toBeDefined();
     expect(transaction.spanRecorder!.spans).toHaveLength(1);