Skip to content

Commit 06d85ca

Browse files
committed
review feedback
1 parent d4900a7 commit 06d85ca

File tree

6 files changed

+44
-59
lines changed

6 files changed

+44
-59
lines changed

packages/feedback/README.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,14 @@
44
</a>
55
</p>
66

7-
# Sentry Feedback
8-
9-
[![npm version](https://img.shields.io/npm/v/@sentry/feedback.svg)](https://www.npmjs.com/package/@sentry/feedback)
10-
[![npm dm](https://img.shields.io/npm/dm/@sentry/feedback.svg)](https://www.npmjs.com/package/@sentry/feedback)
11-
[![npm dt](https://img.shields.io/npm/dt/@sentry/feedback.svg)](https://www.npmjs.com/package/@sentry/feedback)
7+
# Sentry Integration for Feedback
128

139
This SDK is **considered experimental and in an alpha state**. It may experience breaking changes, and may be discontinued at any time. Please reach out on
1410
[GitHub](https://github.com/getsentry/sentry-javascript/issues/new/choose) if you have any feedback/concerns.
1511

1612
## Pre-requisites
1713

18-
`@sentry/feedback` requires Node 12+, and browsers newer than IE11.
14+
`@sentry/feedback` currently can only be used by browsers with [Shadow DOM](https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_shadow_DOM) support.
1915

2016
## Installation
2117

packages/feedback/jest.config.ts

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1 @@
1-
import type { Config } from '@jest/types';
2-
import { jsWithTs as jsWithTsPreset } from 'ts-jest/presets';
3-
4-
export default async (): Promise<Config.InitialOptions> => {
5-
return {
6-
...jsWithTsPreset,
7-
globals: {
8-
'ts-jest': {
9-
tsconfig: '<rootDir>/tsconfig.test.json',
10-
},
11-
__DEBUG_BUILD__: true,
12-
},
13-
setupFilesAfterEnv: ['./jest.setup.ts'],
14-
testEnvironment: 'jsdom',
15-
testMatch: ['<rootDir>/test/**/*(*.)@(spec|test).ts'],
16-
};
17-
};
1+
module.exports = require('../../jest/jest.config.js');

packages/feedback/jest.setup.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/feedback/package.json

Lines changed: 19 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,14 @@
11
{
22
"name": "@sentry-internal/feedback",
33
"version": "7.70.0",
4-
"description": "User feedback for Sentry",
4+
"description": "Sentry SDK integration for user feedback",
5+
"repository": "git://github.com/getsentry/sentry-javascript.git",
6+
"homepage": "https://github.com/getsentry/sentry-javascript/tree/master/packages/feedback",
7+
"author": "Sentry",
8+
"license": "MIT",
9+
"engines": {
10+
"node": ">=12"
11+
},
512
"main": "build/npm/cjs/index.js",
613
"module": "build/npm/esm/index.js",
714
"types": "build/npm/types/index.d.ts",
@@ -12,7 +19,15 @@
1219
]
1320
}
1421
},
15-
"sideEffects": false,
22+
"publishConfig": {
23+
"access": "public"
24+
},
25+
"dependencies": {
26+
"@sentry/core": "7.70.0",
27+
"@sentry/types": "7.70.0",
28+
"@sentry/utils": "7.70.0",
29+
"tslib": "^2.4.1 || ^1.9.3"
30+
},
1631
"scripts": {
1732
"build": "run-p build:transpile build:types build:bundle",
1833
"build:transpile": "rollup -c rollup.npm.config.js",
@@ -39,29 +54,8 @@
3954
"test:watch": "jest --watch",
4055
"yalc:publish": "ts-node ../../scripts/prepack.ts --bundles && yalc publish ./build/npm --push"
4156
},
42-
"repository": {
43-
"type": "git",
44-
"url": "git+https://github.com/getsentry/sentry-javascript.git"
45-
},
46-
"author": "Sentry",
47-
"license": "MIT",
48-
"bugs": {
49-
"url": "https://github.com/getsentry/sentry-javascript/issues"
50-
},
51-
"homepage": "https://docs.sentry.io/platforms/javascript/",
52-
"devDependencies": {
53-
"@babel/core": "^7.17.5",
54-
"tslib": "^2.4.1 || ^1.9.3"
55-
},
56-
"dependencies": {
57-
"@sentry/core": "7.70.0",
58-
"@sentry/types": "7.70.0",
59-
"@sentry/utils": "7.70.0"
60-
},
61-
"engines": {
62-
"node": ">=12"
63-
},
6457
"volta": {
6558
"extends": "../../package.json"
66-
}
59+
},
60+
"sideEffects": false
6761
}

packages/feedback/scripts/craft-pre-release.sh

Lines changed: 0 additions & 8 deletions
This file was deleted.

yarn.lock

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4528,6 +4528,28 @@
45284528
proxy-from-env "^1.1.0"
45294529
which "^2.0.2"
45304530

4531+
"@sentry/core@7.70.0":
4532+
version "7.70.0"
4533+
resolved "https://registry.yarnpkg.com/@sentry/core/-/core-7.70.0.tgz#c481ef27cf05293fb681ee4ff4d4b0b1e8664bb5"
4534+
integrity sha512-voUsGVM+jwRp99AQYFnRvr7sVd2tUhIMj1L6F42LtD3vp7t5ZnKp3NpXagtFW2vWzXESfyJUBhM0qI/bFvn7ZA==
4535+
dependencies:
4536+
"@sentry/types" "7.70.0"
4537+
"@sentry/utils" "7.70.0"
4538+
tslib "^2.4.1 || ^1.9.3"
4539+
4540+
"@sentry/types@7.70.0":
4541+
version "7.70.0"
4542+
resolved "https://registry.yarnpkg.com/@sentry/types/-/types-7.70.0.tgz#c7b533bb18144e3b020550b38cf4812c32d05ffe"
4543+
integrity sha512-rY4DqpiDBtXSk4MDNBH3dwWqfPbNBI/9GA7Y5WJSIcObBtfBKp0fzYliHJZD0pgM7d4DPFrDn42K9Iiumgymkw==
4544+
4545+
"@sentry/utils@7.70.0":
4546+
version "7.70.0"
4547+
resolved "https://registry.yarnpkg.com/@sentry/utils/-/utils-7.70.0.tgz#825387ceb10cbb1e145357394b697a1a6d60eb74"
4548+
integrity sha512-0cChMH0lsGp+5I3D4wOHWwjFN19HVrGUs7iWTLTO5St3EaVbdeLbI1vFXHxMxvopbwgpeZafbreHw/loIdZKpw==
4549+
dependencies:
4550+
"@sentry/types" "7.70.0"
4551+
tslib "^2.4.1 || ^1.9.3"
4552+
45314553
"@sentry/vite-plugin@^0.6.1":
45324554
version "0.6.1"
45334555
resolved "https://registry.yarnpkg.com/@sentry/vite-plugin/-/vite-plugin-0.6.1.tgz#31eb744e8d87b1528eed8d41433647727a62e7c0"

0 commit comments

Comments
 (0)