Skip to content

feat: Support Electron #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2025
Merged

feat: Support Electron #9

merged 3 commits into from
Feb 12, 2025

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 6, 2025

This PR:

  • Uses the @electron/rebuild output path to load the profiling binary if we're running in Electron
    • Logs a warning on error instructing users to use @electron/rebuild when using Electron
  • Adds tests for Electron
  • The bundler tests still pass!
  • Splits the tests into bindings/bundling/electron
    • Only runs the required tests on all platforms and Node versions
    • Keeps all the test dependencies contained within their own tests to keep yarn install times reasonable on Windows

@timfish timfish marked this pull request as ready for review February 6, 2025 13:35
@timfish timfish enabled auto-merge (squash) February 12, 2025 10:46
@timfish timfish merged commit 76d1a63 into main Feb 12, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Electron built output paths
2 participants