feat: Support Node 24

[AbhiPrasad]

ref getsentry/sentry-javascript#16058

resolves https://linear.app/getsentry/issue/FE-419

[timfish]

The auto cancelled builds look due to #11.

Not sure about the windows failure. I can try building on my windows machine if required!

[AbhiPrasad]

Ah yeah we should do a separate PR for #11 - let me open that up first after asking people about what we should do for libc. I don't think its a usage deal to constrain it (though honestly we should have gotten this done in v9)

[timfish]

I think we also need to add an extra Node module abi level to each platform/arch so that pre-built binaries are loaded or bundled:

sentry-javascript-profiling-node-binaries/src/index.ts

Lines 51 to 62 in 7ac5dd2

	if (platform === 'darwin') {
	if (arch === 'x64') {
	if (abi === '108') {
	return require('./sentry_cpu_profiler-darwin-x64-108.node');
	}
	if (abi === '115') {
	return require('./sentry_cpu_profiler-darwin-x64-115.node');
	}
	if (abi === '127') {
	return require('./sentry_cpu_profiler-darwin-x64-127.node');
	}
	}

The abi for v24 is 137:
https://github.com/nodejs/node/blob/9148e965b41dfb322a9e1f38dfaf11ddab0f042c/doc/abi_version_registry.json#L3

[AbhiPrasad]

I think we also need to add an extra Node module abi level to each platform:

I thought these were still in the js repo - good catch! will fix up.

Not sure about the windows failure. I can try building on my windows machine if required!

I thought these were related to C++ 20 but I think I'm wrong. If you could give it a try would be a big help!

[timfish]

Node on Windows now builds with ClangCL so we need to also use that to build our native module.

Bumping the node-gyp devDependency to the latest version appears to fix this!

[AbhiPrasad]

Alright brought back the node-gyp upgrade I erased during the rebase

[timfish]

I can reproduce the test failure on my local machine. Looks like rmSync(tmpDir, { recursive: true, force: true }) fails with File name too long on macOS. Maybe on macOS we need to do the same via the shell rm -rf?

Maybe this is a Node 24 bug 🤷‍♂️

[AbhiPrasad]

If it works on Node 22 it def is a Node bug.

We should try to reproduce it and open an issue with Node. @timfish could you help with that?

[timfish]

When preparing for the tests we clear the yarn cache so that our local packed module gets used. Yarn v1 results in deprecation warnings in Node 24 which were polluting the output when we try and get the cache directory.