Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use sequential and post order for vite artifact deletion #568

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

tyouzu1
Copy link
Contributor

@tyouzu1 tyouzu1 commented Jul 10, 2024

Sometimes writeBundle is executed before the upload task, need to ensure the order of code execution

@tyouzu1
Copy link
Contributor Author

tyouzu1 commented Jul 10, 2024

No other plugins are considered, currently only for reference

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thank you!

@lforst lforst changed the title fix: Keep the deletion task executed last fix: Use sequential and post order for vite artifact deletion Jul 10, 2024
@lforst lforst merged commit e26b875 into getsentry:main Jul 10, 2024
17 checks passed
@tyouzu1
Copy link
Contributor Author

tyouzu1 commented Jul 10, 2024

Lgtm! Thank you!

Too fast , Hope there are no bugs 🥲

By the way, it seems that my electron vite project(used vite-plugin-electron) has the same problem( Triggered multiple deletion task ), Looks like it's all solved.

Thanks again

This was referenced Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants