-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Don't use word "error" in log message about telemetry #548
Merged
lforst
merged 1 commit into
getsentry:main
from
mateusz-daniluk-xtb:improve-log-clarity-telemetry
Jun 17, 2024
Merged
feat: Don't use word "error" in log message about telemetry #548
lforst
merged 1 commit into
getsentry:main
from
mateusz-daniluk-xtb:improve-log-clarity-telemetry
Jun 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the log message in the telemetry plugin to avoid using the word "error," reducing false positives when searching logs. This change improves developer experience during debugging.
mateusz-daniluk-xtb
force-pushed
the
improve-log-clarity-telemetry
branch
from
June 12, 2024 08:29
8272b9d
to
baaa9bd
Compare
lforst
changed the title
feat(telemetry): improve log clarity for telemetry data
feat(telemetry): Improve log clarity for telemetry data
Jun 17, 2024
lforst
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change. Thank you!
lforst
changed the title
feat(telemetry): Improve log clarity for telemetry data
feat(telemetry): Don't use word "error" in log message about telemetry
Jun 17, 2024
lforst
changed the title
feat(telemetry): Don't use word "error" in log message about telemetry
feat: Don't use word "error" in log message about telemetry
Jun 17, 2024
This was referenced Aug 28, 2024
This was referenced Sep 5, 2024
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored a log message in the
telemetry.ts
plugin to improve clarity and reduce false positives when searching for errors in logs.Files Changed
Reason for Changes
The previous log message contained the word "error," which led to confusion when searching for actual errors in the logs using ctrl/cmd + F. The modified message improves the clarity of logs and reduces false positives during searches.
Impact of Changes
Additional Notes
This change aims to enhance developer experience by streamlining the process of locating and addressing genuine errors in the build logs.