ref(core): Use Sentry CLI for artifact deletion

Author: Lms24

packages/bundler-plugin-core/src/sentry/api.ts

@@ -49,34 +49,3 @@ export async function createRelease({
     throw e;
   }
 }
-
-export async function deleteAllReleaseArtifacts({
-  org,
-  project,
-  release,
-  authToken,
-  sentryUrl,
-  sentryHub,
-  customHeader,
-}: {
-  org: string;
-  release: string;
-  sentryUrl: string;
-  authToken: string;
-  project: string;
-  sentryHub: Hub;
-  customHeader: Record<string, string>;
-}): Promise<void> {
-  const requestUrl = `${sentryUrl}${API_PATH}/projects/${org}/${project}/files/source-maps/?name=${release}`;
-
-  try {
-    await sentryApiAxiosInstance({ authToken, customHeader }).delete(requestUrl, {
-      headers: {
-        Authorization: `Bearer ${authToken}`,
-      },
-    });
-  } catch (e) {
-    captureMinimalError(e, sentryHub);
-    throw e;
-  }
-}

packages/bundler-plugin-core/src/sentry/cli.ts

@@ -2,7 +2,7 @@ import SentryCli, { SentryCliReleases } from "@sentry/cli";
 import { InternalOptions } from "../options-mapping";
 import { Logger } from "./logger";
 
-type SentryDryRunCLI = { releases: Omit<SentryCliReleases, "listDeploys" | "execute"> };
+type SentryDryRunCLI = { releases: Omit<SentryCliReleases, "listDeploys"> };
 export type SentryCLILike = SentryCli | SentryDryRunCLI;
 
 /**
@@ -57,6 +57,10 @@ function getDryRunCLI(cli: SentryCli, logger: Logger): SentryDryRunCLI {
         logger.info("Calling deploy with:\n", config);
         return Promise.resolve(release);
       },
+      execute: (args: string[], live: boolean) => {
+        logger.info("Executing", args, "live:", live);
+        return Promise.resolve("");
+      },
     },
   };
 }

packages/bundler-plugin-core/src/sentry/releasePipeline.ts

@@ -8,7 +8,7 @@
 
 import { InternalOptions } from "../options-mapping";
 import { BuildContext } from "../types";
-import { createRelease, deleteAllReleaseArtifacts } from "./api";
+import { createRelease } from "./api";
 import { addSpanToTransaction } from "./telemetry";
 
 export async function createNewRelease(
@@ -86,40 +86,31 @@ export async function finalizeRelease(options: InternalOptions, ctx: BuildContex
   span?.finish();
 }
 
-export async function cleanArtifacts(options: InternalOptions, ctx: BuildContext): Promise<string> {
+export async function cleanArtifacts(options: InternalOptions, ctx: BuildContext): Promise<void> {
   const span = addSpanToTransaction(ctx, "function.plugin.clean_artifacts");
 
   if (options.cleanArtifacts) {
     // TODO: pull these checks out of here and simplify them
     if (options.authToken === undefined) {
       ctx.logger.warn('Missing "authToken" option. Will not clean existing artifacts.');
-      return Promise.resolve("nothing to do here");
+      return;
     } else if (options.org === undefined) {
       ctx.logger.warn('Missing "org" option. Will not clean existing artifacts.');
-      return Promise.resolve("nothing to do here");
+      return;
     } else if (options.url === undefined) {
       ctx.logger.warn('Missing "url" option. Will not clean existing artifacts.');
-      return Promise.resolve("nothing to do here");
+      return;
     } else if (options.project === undefined) {
       ctx.logger.warn('Missing "project" option. Will not clean existing artifacts.');
-      return Promise.resolve("nothing to do here");
+      return;
     }
 
-    await deleteAllReleaseArtifacts({
-      authToken: options.authToken,
-      org: options.org,
-      release: options.release,
-      sentryUrl: options.url,
-      project: options.project,
-      sentryHub: ctx.hub,
-      customHeader: options.customHeader,
-    });
+    await ctx.cli.releases.execute(["releases", "files", options.release, "delete", "--all"], true);
 
     ctx.logger.info("Successfully cleaned previous artifacts.");
   }
 
   span?.finish();
-  return Promise.resolve("nothing to do here");
 }
 
 // TODO: Stuff we worry about later: