Removed SentryExecutorService limit #4846
Open
+38
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanosiano
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
| 96449e8 | 361.30 ms | 423.39 ms | 62.09 ms |
| ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
| 3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
| b3d8889 | 371.84 ms | 447.49 ms | 75.65 ms |
| 27d7cf8 | 369.82 ms | 422.62 ms | 52.80 ms |
| d364ace | 411.72 ms | 430.81 ms | 19.10 ms |
| 7314dbe | 437.83 ms | 505.64 ms | 67.81 ms |
| ce0a49e | 532.00 ms | 609.96 ms | 77.96 ms |
| 3998a95 | 415.94 ms | 478.54 ms | 62.60 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 96449e8 | 1.58 MiB | 2.11 MiB | 539.35 KiB |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| b3d8889 | 1.58 MiB | 2.10 MiB | 535.07 KiB |
| 27d7cf8 | 1.58 MiB | 2.12 MiB | 549.42 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| 7314dbe | 1.58 MiB | 2.10 MiB | 533.45 KiB |
| ce0a49e | 1.58 MiB | 2.10 MiB | 532.94 KiB |
| 3998a95 | 1.58 MiB | 2.10 MiB | 532.96 KiB |
Previous results on branch: stefanosiano/fix/remove-executor-service-limit
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 01d0a7e | 323.23 ms | 389.35 ms | 66.12 ms |
| 42b3e9b | 322.84 ms | 365.04 ms | 42.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 01d0a7e | 1.58 MiB | 2.12 MiB | 551.16 KiB |
| 42b3e9b | 1.58 MiB | 2.12 MiB | 551.16 KiB |
…-service-limit' into stefanosiano/fix/remove-executor-service-limit
romtsn
reviewed
Oct 29, 2025
submit() now tries to purge if it reaches the limit
…-service-limit' into stefanosiano/fix/remove-executor-service-limit
romtsn
reviewed
Nov 3, 2025
| private boolean isQueueAvailable() { | ||
| // If limit is reached, purge cancelled tasks from the queue | ||
| if (executorService.getQueue().size() >= MAX_QUEUE_SIZE) { | ||
| executorService.purge(); |
There was a problem hiding this comment.
hm, but this means now we're dropping existing tasks as opposed to dropping the new incoming ones. What's the intention behind?
There was a problem hiding this comment.
purge just removes cancelled futures from the queue, otherwise they would still be included in the queue and its size
We're not dropping anything, other than tasks that would not be run anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
removed
SentryExecutorServicemax queue limit💡 Motivation and Context
Some critical SDK internal operation depend on our
SentryExecutorService, so it's better to avoid losing any scheduled job, or we risk things like #4841💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps