Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Oct 1, 2025

📜 Description

Use the logger from options when loading and running the profiler.
Otherwise, you would log everything to stdout even if debug: false.

Close #4772
Close JAVA-193

@lcian lcian force-pushed the lcian/profiling-logger branch from a7f5d47 to 7e2905b Compare October 1, 2025 14:10
@lcian lcian changed the base branch from main to lcian-patch-1 October 1, 2025 14:10
@linear
Copy link

linear bot commented Oct 1, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 410.31 ms 467.50 ms 57.19 ms
Size 1.58 MiB 2.10 MiB 535.07 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b750b96 421.25 ms 444.09 ms 22.84 ms
23d6b12 354.10 ms 408.38 ms 54.28 ms
ee747ae 405.43 ms 485.70 ms 80.28 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
d217708 375.27 ms 415.68 ms 40.41 ms
c8125f3 383.82 ms 441.66 ms 57.84 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms

App size

Revision Plain With Sentry Diff
b750b96 1.58 MiB 2.10 MiB 533.20 KiB
23d6b12 1.58 MiB 2.10 MiB 532.31 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
d217708 1.58 MiB 2.10 MiB 532.97 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: lcian/profiling-logger

Startup times

Revision Plain With Sentry Diff
4cd4bf5 381.68 ms 472.49 ms 90.81 ms

App size

Revision Plain With Sentry Diff
4cd4bf5 1.58 MiB 2.10 MiB 535.06 KiB

Base automatically changed from lcian-patch-1 to main October 1, 2025 15:58
@adinauer
Copy link
Member

adinauer commented Oct 2, 2025

Can we wait for @lbloder to review this before merging please? Maybe there's a reason for this.

@adinauer adinauer requested a review from lbloder October 2, 2025 07:14
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcian Good catch, missed that when reviewing my code before merging back.

@lcian lcian merged commit b3d8889 into main Oct 2, 2025
61 checks passed
@lcian lcian deleted the lcian/profiling-logger branch October 2, 2025 09:37
romtsn pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JVM Profiler uses stdout logger

5 participants