Skip to content

Conversation

markushi
Copy link
Member

@markushi markushi commented Sep 9, 2025

📜 Description

Unsure about

  • ktor (switched to 1.9.24)
  • UI test dependencies (switched to 1.9.24)
  • samples (stuck with compiler version)

💡 Motivation and Context

💚 How did you test it?

Manually, using the socialite app @ Kotlin 1.9.x
and Kotlin 2.x (main branch).

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 356.22 ms 445.65 ms 89.43 ms
Size 1.58 MiB 2.10 MiB 532.10 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b750b96 421.25 ms 444.09 ms 22.84 ms
674d437 355.28 ms 504.18 ms 148.90 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 382.73 ms 435.41 ms 52.68 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms

App size

Revision Plain With Sentry Diff
b750b96 1.58 MiB 2.10 MiB 533.20 KiB
674d437 1.58 MiB 2.10 MiB 530.94 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

@markushi markushi marked this pull request as ready for review September 9, 2025 12:14
api(projects.sentry)

implementation(kotlin(Config.kotlinStdLib, KotlinCompilerVersion.VERSION))
implementation(kotlin(Config.kotlinStdLib, Config.kotlinStdLibVersionAndroid))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incorrect Android Kotlin Stdlib in JVM Modules

The sentry-ktor-client and sentry-okhttp modules are JVM-only libraries (using java-library and kotlin.jvm plugins), but they're now using Config.kotlinStdLibVersionAndroid. This Android-specific Kotlin stdlib version appears to be incorrectly applied to these non-Android modules, which could lead to compatibility issues and contradicts the PR's stated intent.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markushi markushi merged commit 16a31b3 into main Sep 9, 2025
42 of 43 checks passed
@markushi markushi deleted the markushi/fix/kotlin-stdlib-dependency branch September 9, 2025 13:29
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Use Kotlin stdlib 1.9.24 dependency for Android modules ([#4707](https://github.com/getsentry/sentry-java/pull/4707))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 59862ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants