-
-
Notifications
You must be signed in to change notification settings - Fork 459
Use Kotlin stdlib 1.9.24 dependency for Android modules #4707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b750b96 | 421.25 ms | 444.09 ms | 22.84 ms |
674d437 | 355.28 ms | 504.18 ms | 148.90 ms |
ee747ae | 358.21 ms | 389.41 ms | 31.20 ms |
ee747ae | 396.82 ms | 441.67 ms | 44.86 ms |
85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
3699cd5 | 423.60 ms | 495.52 ms | 71.92 ms |
ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
ee747ae | 554.98 ms | 611.50 ms | 56.52 ms |
ee747ae | 382.73 ms | 435.41 ms | 52.68 ms |
ee747ae | 374.71 ms | 455.18 ms | 80.47 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b750b96 | 1.58 MiB | 2.10 MiB | 533.20 KiB |
674d437 | 1.58 MiB | 2.10 MiB | 530.94 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
3699cd5 | 1.58 MiB | 2.10 MiB | 533.45 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
api(projects.sentry) | ||
|
||
implementation(kotlin(Config.kotlinStdLib, KotlinCompilerVersion.VERSION)) | ||
implementation(kotlin(Config.kotlinStdLib, Config.kotlinStdLibVersionAndroid)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incorrect Android Kotlin Stdlib in JVM Modules
The sentry-ktor-client
and sentry-okhttp
modules are JVM-only libraries (using java-library
and kotlin.jvm
plugins), but they're now using Config.kotlinStdLibVersionAndroid
. This Android-specific Kotlin stdlib version appears to be incorrectly applied to these non-Android modules, which could lead to compatibility issues and contradicts the PR's stated intent.
Additional Locations (1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Use Kotlin stdlib 1.9.24 dependency for Android modules ([#4707](https://github.com/getsentry/sentry-java/pull/4707)) If none of the above apply, you can opt out of this check by adding |
📜 Description
Unsure about
ktor
(switched to 1.9.24)💡 Motivation and Context
💚 How did you test it?
Manually, using the socialite app @ Kotlin 1.9.x
and Kotlin 2.x (main branch).
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps