Improve callback handling and test visibility #4593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
romtsn,
stefanosiano and
lcian
as code owners
7 tasks
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 985e191 | 381.06 ms | 407.08 ms | 26.02 ms |
| 8926466 | 426.41 ms | 462.50 ms | 36.09 ms |
| 6fd675a | 403.43 ms | 446.55 ms | 43.13 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 985e191 | 1.58 MiB | 2.09 MiB | 521.14 KiB |
| 8926466 | 1.58 MiB | 2.09 MiB | 521.82 KiB |
| 6fd675a | 1.58 MiB | 2.09 MiB | 521.12 KiB |
romtsn
added a commit
that referenced
this pull request
Aug 5, 2025
* perf(connectivity): Cache network capabilities and status to reduce IPC calls * changelog * Changelog * revert * fix(breadcrumbs): Deduplicate battery breadcrumbs * ref * Changelog * Fix test * perf(connectivity): Have only one NetworkCallback active at a time * Changelog * perf(integrations): Use single lifecycle observer * Add tests * Changelog * Fix tests * Improve callback handling and test visibility (#4593) * Null-check lifecycleObserver --------- Co-authored-by: Markus Hintersteiner <markus.hintersteiner@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
#skip-changelog
Just some minor nits:
💚 How did you test it?
Added unit tests.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps