Skip to content

Commit 5ae3e11

Browse files
committed
Address PR feedback
1 parent 8a49e18 commit 5ae3e11

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

sentry-android-core/src/main/java/io/sentry/android/core/anr/AnrCulpritIdentifier.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,9 @@ public static AggregatedStackTrace identify(final @NotNull List<AnrStackTrace> s
149149
return Collections.max(
150150
stackTraceMap.values(),
151151
(c1, c2) ->
152-
Float.compare(c1.count * c1.quality * c1.depth, c2.count * c2.quality * c2.depth));
152+
Float.compare(
153+
c1.count * (1.0f + c1.quality) * c1.depth,
154+
c2.count * (1.0f + c2.quality) * c2.depth));
153155
}
154156

155157
public static boolean isSystemFrame(final @NotNull String clazz) {

sentry-android-core/src/main/java/io/sentry/android/core/anr/AnrProfileManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ public void toStream(
7676
try (final @NotNull DataOutputStream dos = new DataOutputStream(sink)) {
7777
value.serialize(dos);
7878
dos.flush();
79+
sink.flush();
7980
}
80-
sink.flush();
8181
}
8282
});
8383
}

sentry-android-core/src/test/java/io/sentry/android/core/anr/AnrCulpritIdentifierTest.kt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,7 @@ class AnrCulpritIdentifierTest {
8787
StackTraceElement("android.os.Handler", "handleMessage", "Handler.java", 100),
8888
)
8989

90-
val dumps =
91-
listOf(
92-
AnrStackTrace(1000, frameworkElements),
93-
AnrStackTrace(2000, frameworkElements),
94-
AnrStackTrace(3000, appElements),
95-
)
90+
val dumps = listOf(AnrStackTrace(1000, frameworkElements), AnrStackTrace(2000, appElements))
9691

9792
val result = AnrCulpritIdentifier.identify(dumps)
9893

0 commit comments

Comments
 (0)