-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update caching transport and tests #1617
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjohnsonpint
requested review from
bruno-garcia and
SimonCropp
as code owners
April 29, 2022 23:17
Looks like there's still a race condition in the |
mattjohnsonpint
changed the title
Update caching transport tests
Update caching transport and tests
Apr 30, 2022
It's good at this point, but I see a few more related improvements to make. More coming shortly. 😉 |
Good enough for now. Ready for review. Thanks. |
SimonCropp
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to the caching transport, mostly around tests:
startWorker
that can be setfalse
on these tests to just not have a worker started to begin with.AwareOfExistingFiles
test was passing, but wasn't actually testing what we thought it was. It does now.WorksInBackground
test was watching the directory to know when it was finished. Rewrote to watch an event fired on the inner transport. No need to watch the directory at all now.