Added SentryAspNetCoreOptions.AdjustStandardEnvironmentNameCasing to … #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have sentry avoid modifying the case of the standard ASPNET_ENVIRONMENT names when determining the sentry environment.
Tyrrrz
reviewed
Jun 15, 2021
test/Sentry.AspNetCore.Tests/SentryAspNetCoreOptionsSetupTests.cs
Outdated
Show resolved
Hide resolved
|
Also please update - Added SentryAspNetCoreOptions.AdjustStandardEnvironmentNameCasing to control whether to transform the environment name to lower case or to keep it as is. [#1057](https://github.com/getsentry/sentry-dotnet/pull/1057) |
Co-authored-by: Alexey Golub <tyrrrrrr@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1057 +/- ##
==========================================
- Coverage 81.31% 81.30% -0.01%
==========================================
Files 193 193
Lines 6335 6338 +3
Branches 1527 1528 +1
==========================================
+ Hits 5151 5153 +2
Misses 747 747
- Partials 437 438 +1
Continue to review full report at Codecov.
|
added 5 commits
June 16, 2021 09:25
…sts to make more focused.
Tyrrrz
approved these changes
Jun 16, 2021
|
@bruno-garcia looks good? |
…ing-dotnetcore-option
bruno-garcia
approved these changes
Jun 16, 2021
…ing-dotnetcore-option
ajbeaven
deleted the
feature/add-AdjustStandardEnvironmentNameCasing-dotnetcore-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…have sentry avoid modifying the case of the standard ASPNET_ENVIRONMENT names when determining the sentry environment.
Fixes #999.