Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Don't expose internals #17

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

bruno-garcia
Copy link
Member

@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #17 into master will decrease coverage by 3.97%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   98.14%   94.17%   -3.98%     
==========================================
  Files          22       24       +2     
  Lines         432      584     +152     
==========================================
+ Hits          424      550     +126     
- Misses          8       34      +26
Impacted Files Coverage Δ
src/Sentry.Protocol/SentryEventExtensions.cs 0% <0%> (ø)
src/Sentry.Protocol/SentryEvent.cs 100% <100%> (ø) ⬆️
src/Sentry.Protocol/BaseScopeExtensions.cs 78.14% <78.14%> (ø)
src/Sentry.Protocol/BaseScope.cs 100% <0%> (+9.09%) ⬆️
src/Sentry.Protocol/CollectionsExtensions.cs 100% <0%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd84ccb...027fbfa. Read the comment docs.

@bruno-garcia bruno-garcia merged commit a1f4a14 into master Oct 1, 2018
@bruno-garcia bruno-garcia deleted the ref/remove-internals-visible-to-sentry branch October 1, 2018 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants