Skip to content

Java: document Apollo Android integration #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 4, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

Fixes #4151

@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/HUX9ZyD73rvW5P2Vx5SEYJwMfcfA
✅ Preview: https://sentry-docs-git-fork-maciejwalkowiak-gh-4151.sentry.dev

@maciejwalkowiak
Copy link
Contributor Author

@marandaneto what was the trick to have this guide also in Android space without duplicating the content?

@marandaneto
Copy link
Contributor

@marandaneto what was the trick to have this guide also in Android space without duplicating the content?

tricky, indeed, either the whole content goes to an include file, and both platforms use the included file or we just duplicate and adapt them, since there are a few differences, eg, single hub/scope isn't important for Android, Android also does not need the SBT/Maven dependency and other small tweaks if necessary

@maciejwalkowiak
Copy link
Contributor Author

To be honest, I am not convinced SBT dependencies make even sense for Java.

@marandaneto
Copy link
Contributor

To be honest, I am not convinced SBT dependencies make even sense for Java.

happy to skip them as well and maybe even removing all SBT from other files, tbh Ive never used or heard too much about it

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor style fixes

…o.mdx

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
maciejwalkowiak and others added 2 commits September 30, 2021 09:52
…o.mdx

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
…o.mdx

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@maciejwalkowiak
Copy link
Contributor Author

Thanks @imatwawana! Same changes applied also to Java variant. @marandaneto please take another look.

@marandaneto
Copy link
Contributor

Thanks @imatwawana! Same changes applied also to Java variant. @marandaneto please take another look.

thanks, left 2 comments but its ready to go, we need to address getsentry/sentry-java#1723 first, before merging this docs, there's a comment in one of the PRs btw

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small grammar and style fixes

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@marandaneto marandaneto merged commit 4d74254 into getsentry:master Oct 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Apollo integration for Java/Android
3 participants