-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Java: document Apollo Android integration #4202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sentry/sentry-docs/HUX9ZyD73rvW5P2Vx5SEYJwMfcfA |
@marandaneto what was the trick to have this guide also in Android space without duplicating the content? |
tricky, indeed, either the whole content goes to an include file, and both platforms use the included file or we just duplicate and adapt them, since there are a few differences, eg, single hub/scope isn't important for Android, Android also does not need the SBT/Maven dependency and other small tweaks if necessary |
To be honest, I am not convinced SBT dependencies make even sense for Java. |
happy to skip them as well and maybe even removing all SBT from other files, tbh Ive never used or heard too much about it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor style fixes
src/platforms/android/common/performance/instrumentation/apollo.mdx
Outdated
Show resolved
Hide resolved
src/platforms/android/common/performance/instrumentation/apollo.mdx
Outdated
Show resolved
Hide resolved
src/platforms/android/common/performance/instrumentation/apollo.mdx
Outdated
Show resolved
Hide resolved
…o.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
…o.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
…o.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Thanks @imatwawana! Same changes applied also to Java variant. @marandaneto please take another look. |
src/platforms/android/common/performance/instrumentation/apollo.mdx
Outdated
Show resolved
Hide resolved
src/platforms/android/common/performance/instrumentation/apollo.mdx
Outdated
Show resolved
Hide resolved
thanks, left 2 comments but its ready to go, we need to address getsentry/sentry-java#1723 first, before merging this docs, there's a comment in one of the PRs btw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small grammar and style fixes
src/platforms/android/common/performance/instrumentation/apollo.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Fixes #4151