-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref: add minimum required OS version for relay binary #13899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
| MacOS | macOS Sonoma (version 14) | | ||
| Windows | Windows Server 2019 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we guarantee MacOS and WIndows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have runners for those, or do you mean what would happen if Github discontinues those before the offical EOL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or are you suggesting to only mention Ubuntu in the table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have runners for those, or do you mean what would happen if Github discontinues those before the offical EOL?
Correct, how do we guarantee what you documented here, it's the same with ubuntu, github turned off the runners before the actual EOL. So if we promise it here, how do we make sure we can hold that promise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Should wait for a docs team review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good! (also, please tag the docs team when y'all are ready for review in future PRs)
…itles-logger-details * fix-restoring-cloudflare-guides: standardizing titles Updating description Restoring guides for cloudflare frameworks chore(platform): Move next config file + bump sentry (#13932) feat(apple): Code for NSExceptions in configure (#13941) ref: add minimum required OS version for relay binary (#13899) fix(llm-rules-platform): Fix typo (#13942) Update Python migration guide (#13939) docs(js): Add alert on auto-instrumentation for react-router framework (#13929) feat: Improve Cloudflare and Hono docs (#13938) feat: Improve Hono docs to cover errors + Node.js (#13936) feat(native): reflect windows support for crashpad-wait-for-upload in… (#13864) feat(native): reflect windows support for crashpad-wait-for-upload in… (#13865) ref(docs): update instances of yarn dev-ui to be pnpm (#13935) feat(native): reflect windows support for crashpad-wait-for-upload in… (#13863) chore(plugins): Reflect deprecation in the docs (#13812)
DESCRIBE YOUR PR
Adds description with versions for relay binaries and how long we support each operating system.
I also added a description to the build config to update the documentation in case it gets updated: getsentry/relay#4794