Skip to content

ref: add minimum required OS version for relay binary #13899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025

Conversation

Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Jun 2, 2025

DESCRIBE YOUR PR

Adds description with versions for relay binaries and how long we support each operating system.

I also added a description to the build config to update the documentation in case it gets updated: getsentry/relay#4794

Copy link

vercel bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 2:50pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 2:50pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2025 2:50pm

Copy link

codecov bot commented Jun 2, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.22MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.77MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/M03xWn7jwXcXrFTxgr6Nr/_buildManifest.js (New) 616 bytes 616 bytes 100.0% 🚀
static/M03xWn7jwXcXrFTxgr6Nr/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/pZYHtjkEsv25Iq8wiUuk3/_buildManifest.js (Deleted) -616 bytes 0 bytes -100.0% 🗑️
static/pZYHtjkEsv25Iq8wiUuk3/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

Comment on lines 42 to 43
| MacOS | macOS Sonoma (version 14) |
| Windows | Windows Server 2019 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we guarantee MacOS and WIndows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have runners for those, or do you mean what would happen if Github discontinues those before the offical EOL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or are you suggesting to only mention Ubuntu in the table?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have runners for those, or do you mean what would happen if Github discontinues those before the offical EOL?

Correct, how do we guarantee what you documented here, it's the same with ubuntu, github turned off the runners before the actual EOL. So if we promise it here, how do we make sure we can hold that promise.

Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Should wait for a docs team review

@sfanahata sfanahata self-requested a review June 5, 2025 21:36
Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! (also, please tag the docs team when y'all are ready for review in future PRs)

@Litarnus Litarnus merged commit 7249825 into master Jun 6, 2025
13 checks passed
@Litarnus Litarnus deleted the martinl/relay-binary-os-version branch June 6, 2025 11:30
codyde added a commit that referenced this pull request Jun 6, 2025
…itles-logger-details

* fix-restoring-cloudflare-guides:
  standardizing titles
  Updating description
  Restoring guides for cloudflare frameworks
  chore(platform): Move next config file + bump sentry (#13932)
  feat(apple): Code for NSExceptions in configure (#13941)
  ref: add minimum required OS version for relay binary (#13899)
  fix(llm-rules-platform): Fix typo (#13942)
  Update Python migration guide (#13939)
  docs(js): Add alert on auto-instrumentation for react-router framework (#13929)
  feat: Improve Cloudflare and Hono docs (#13938)
  feat: Improve Hono docs to cover errors + Node.js (#13936)
  feat(native): reflect windows support for crashpad-wait-for-upload in… (#13864)
  feat(native): reflect windows support for crashpad-wait-for-upload in… (#13865)
  ref(docs): update instances of yarn dev-ui to be pnpm (#13935)
  feat(native): reflect windows support for crashpad-wait-for-upload in… (#13863)
  chore(plugins): Reflect deprecation in the docs (#13812)
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants