feat(native): update transaction docs #13715
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 228 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
|
||
| In its simplest form, used just for filtering the transaction, it looks like this: | ||
|
|
||
| <PlatformContent includePath="performance/traces-sampler-as-sampler" /> |
There was a problem hiding this comment.
Other SDKs use a separate example (traces-sampler-as-filter) but in our docs for completeness sake this would need to look very similar to the existing sampler-as-sampler example, so I opted to just point to the same one we already use in our Sampling docs.
There was a problem hiding this comment.
To be honest, I don't really see the difference in the Android example either. Both show that you change the rate based on some X. One can probably be dropped in, whereas the other drops the concrete conditionals for prose.
Maybe I am blind, but sampling and filtering based on a dice roll seem like the same thing to me. What do the docs try to achieve by marking the distinction? Or is this only about the surrounding text?
In any case, I think linking this is fine.
|
|
||
| In its simplest form, used just for filtering the transaction, it looks like this: | ||
|
|
||
| <PlatformContent includePath="performance/traces-sampler-as-sampler" /> |
There was a problem hiding this comment.
To be honest, I don't really see the difference in the Android example either. Both show that you change the rate based on some X. One can probably be dropped in, whereas the other drops the concrete conditionals for prose.
Maybe I am blind, but sampling and filtering based on a dice roll seem like the same thing to me. What do the docs try to achieve by marking the distinction? Or is this only about the surrounding text?
In any case, I think linking this is fine.
DESCRIBE YOUR PR
Part of getsentry/sentry-native#1236
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.