Skip to content

docs(js): Add Meta-framework settings for filter integration #12940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 6, 2025

DESCRIBE YOUR PR

The code snippets for adding options to the bundler plugins in Meta-framework SDKs are misleading as they show usage of each bundler plugins. However, the Meta-frameworks already include those plugins under the hood and the options should be passed differently.

related to this issue: getsentry/sentry-javascript#13286

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 9:58am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Mar 6, 2025 9:58am
develop-docs ⬜️ Ignored (Inspect) Mar 6, 2025 9:58am

Copy link

codecov bot commented Mar 6, 2025

Bundle Report

Changes will increase total bundle size by 1.64kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.55MB 1.64kB (0.02%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%
../app/[[...path]]/page.js.nft.json 550 bytes 383.68kB 0.14%
../app/platform-redirect/page.js.nft.json 550 bytes 383.59kB 0.14%
../app/sitemap.xml/route.js.nft.json 550 bytes 381.56kB 0.14%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.18kB -0.0%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
static/1C5EdHxKrXWqih87N5_LI/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/1C5EdHxKrXWqih87N5_LI/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/qHraGOpxro1P9-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/qHraGOpxro1P9-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@s1gr1d s1gr1d merged commit 1a17183 into master Mar 6, 2025
11 checks passed
@s1gr1d s1gr1d deleted the sig/filterIntegration-plugin-key branch March 6, 2025 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants