Skip to content

docs(v9/js): Update beforeSendSpan documentation #12233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

chargome
Copy link
Member

@chargome chargome commented Jan 2, 2025

🚨 DO NOT MERGE THIS BEFORE JS SDK V9 has shipped

This pr updates the documentation of the behaviour of beforeSendSpan in the v9 JS SDK.

documents getsentry/sentry-javascript#14831

@chargome chargome self-assigned this Jan 2, 2025
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 3:38pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Jan 2, 2025 3:38pm
develop-docs ⬜️ Ignored (Inspect) Jan 2, 2025 3:38pm

Copy link

codecov bot commented Jan 2, 2025

Bundle Report

Changes will decrease total bundle size by 258 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.36MB 252 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.28MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@getsantry getsantry bot added the Stale label Jan 25, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Jan 25, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot removed the Stale label Jan 26, 2025
@chargome chargome marked this pull request as ready for review February 10, 2025 11:33
@chargome chargome merged commit 889ef7e into master Feb 10, 2025
11 checks passed
@chargome chargome deleted the cg/update-before-send-span branch February 10, 2025 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants